Closed
Bug 1158973
Opened 9 years ago
Closed 9 years ago
Use $httpProvider's applyAsync to reduce digest cycles during some operations
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
We often make concurrent requests in treeherder. Instead of running an angular digest cycle after each one returns, we should defer slightly so we can handle a bunch of DOM updates in one shot by setting useApplyAsync on the $httpProvider class. https://docs.angularjs.org/api/ng/provider/$httpProvider
Assignee | ||
Comment 1•9 years ago
|
||
With this change:
1. When loading page first time, go from 1688ms in requestLoaded callback (triggered digest) to 1340msec in deferred digest callback
2. When loading 50 more jobs, go from 2630ms in requestLoaded callback (triggered digest) to 1934msec in deferred digest callback. Also spend 2000msec less in generateJobElements
3. When loading job details, go from 2400msec in requestLoaded callback (triggered digest) to 823msec in deferred digest callback.
Attachment #8598217 -
Flags: review?(mdoglio)
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8598217 -
Flags: review?(mdoglio) → review+
Comment 2•9 years ago
|
||
This is a great idea! I didn't even know it existed :-)
Comment 3•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-ui
https://github.com/mozilla/treeherder-ui/commit/ad8a39253a1a79933c374786826a9cd841cb6247
Bug 1158973 - Batch digest updates when http requests return
Assignee | ||
Comment 4•9 years ago
|
||
Yeah it's pretty cool!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•9 years ago
|
||
Comment 6•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/3efbfc5f3cd24f6ec738b6b1004ecc21dace3720
Bug 1158973 - Batch digest updates when http requests return
You need to log in
before you can comment on or make changes to this bug.
Description
•