Since writing-mode is not applied to those frames, they should override GetWritingMode() to return the writing-mode of the table frame they belong to.

Comment on attachment 8598425 [details] [diff] [review] patch Review of attachment 8598425 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/tables/nsTableColFrame.h @@ +73,5 @@ > virtual nsSplittableType GetSplittableType() const override; > > + virtual mozilla::WritingMode GetWritingMode() const override > + { > + nsIFrame* grandparent = GetParent()->GetParent(); nsTableFrame::GetTableFrame(this) ::: layout/tables/nsTableColGroupFrame.h @@ +115,5 @@ > virtual nsIAtom* GetType() const override; > > + virtual mozilla::WritingMode GetWritingMode() const override > + { > + nsIFrame* parent = GetParent(); nsTableFrame::GetTableFrame(this) ::: layout/tables/nsTableRowFrame.h @@ +102,5 @@ > + > + virtual mozilla::WritingMode GetWritingMode() const override > + { > + nsIFrame* grandparent = GetParent()->GetParent(); > + MOZ_ASSERT(grandparent->GetType() == nsGkAtoms::tableFrame); nsTableFrame::GetTableFrame(this) ::: layout/tables/nsTableRowGroupFrame.h @@ +120,5 @@ > > + virtual mozilla::WritingMode GetWritingMode() const override > + { > + nsIFrame* parent = GetParent(); > + MOZ_ASSERT(parent->GetType() == nsGkAtoms::tableFrame); nsTableFrame::GetTableFrame(this)

/r/7815 - Bug 1159101 part 1 - Alter dependencies among headers of table struct frames. /r/7817 - Bug 1159101 part 2 - Add GetTableFrame() for table inner frames. /r/7819 - Bug 1159101 part 3 - Replace most of nsTableFrame::GetTableFrame() usage with new GetTableFrame() methods. /r/7821 - Bug 1159101 part 4 - Override GetWritingMode() in nsTable{{Col,Row}{,Group},Cell}Frame. Pull down these commits: hg pull -r cc604a67a3e0955886909d5f895392a502c9bbc1 https://reviewboard-hg.mozilla.org/gecko/

https://reviewboard.mozilla.org/r/7815/#review6607 ::: layout/tables/nsTableFrame.h:102 (Diff revision 1) > + eColGroupContent = 0, // there is real col group content associated Remove trailing whitespace

https://reviewboard.mozilla.org/r/7815/#review6609 Ship It!

https://reviewboard.mozilla.org/r/7817/#review6611 Ship It!

https://reviewboard.mozilla.org/r/7819/#review6613 Ship It!

https://reviewboard.mozilla.org/r/7821/#review6615 Ship It!

Comment on attachment 8599022 [details] MozReview Request: bz://1159101/xidorn /r/7815 - Bug 1159101 part 1 - Alter dependencies among headers of table struct frames. r=roc /r/7817 - Bug 1159101 part 2 - Add GetTableFrame() for table inner frames. r=roc /r/7819 - Bug 1159101 part 3 - Replace most of nsTableFrame::GetTableFrame() usage with new GetTableFrame() methods. r=roc /r/7821 - Bug 1159101 part 4 - Override GetWritingMode() in nsTable{{Col,Row}{,Group},Cell}Frame. r=roc Pull down these commits: hg pull -r a94df6c7b2ab8de09813900e3911b762bec6b176 https://reviewboard-hg.mozilla.org/gecko/

Comment on attachment 8599022 [details] MozReview Request: bz://1159101/xidorn /r/7815 - Bug 1159101 part 1 - Alter dependencies among headers of table struct frames. r=roc /r/7817 - Bug 1159101 part 2 - Add GetTableFrame() for table inner frames. r=roc /r/7819 - Bug 1159101 part 3 - Replace most of nsTableFrame::GetTableFrame() usage with new GetTableFrame() methods. r=roc /r/7821 - Bug 1159101 part 4 - Override GetWritingMode() in nsTable{{Col,Row}{,Group},Cell}Frame. Pull down these commits: hg pull -r ed8cc08fb99c8baeae5277eed2b7b5727914861c https://reviewboard-hg.mozilla.org/gecko/

I changed one line in part 4, could you review that?

https://reviewboard.mozilla.org/r/7821/#review6619 Ship It!

https://hg.mozilla.org/integration/mozilla-inbound/rev/87199dc0f40d https://hg.mozilla.org/integration/mozilla-inbound/rev/5dbe3d837f77 https://hg.mozilla.org/integration/mozilla-inbound/rev/b9ce8e185fcd https://hg.mozilla.org/integration/mozilla-inbound/rev/59fa1317db41

Comment on attachment 8599699 [details] [diff] [review] patch 5 - fix table cell frame init Review of attachment 8599699 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/base/nsCSSFrameConstructor.cpp @@ +8694,2 @@ > nsTableCellFrame* cellFrame = > + NS_NewTableCellFrame(shell, styleContext, tableFrame); This isn't the right table frame. Get it from aParentFrame.

https://hg.mozilla.org/mozilla-central/rev/87199dc0f40d https://hg.mozilla.org/mozilla-central/rev/5dbe3d837f77 https://hg.mozilla.org/mozilla-central/rev/b9ce8e185fcd https://hg.mozilla.org/mozilla-central/rev/59fa1317db41 https://hg.mozilla.org/mozilla-central/rev/91674f65637c