Closed
Bug 1077521
Opened 10 years ago
Closed 6 years ago
vertical writing mode support for tables
Categories
(Core :: Layout: Tables, defect)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
People
(Reporter: jfkthame, Assigned: jfkthame)
References
(Depends on 6 open bugs, Blocks 3 open bugs)
Details
(Keywords: css3, intl, testcase)
Attachments
(4 files)
(deleted),
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
The content of table cells should largely be handled by the general writing-mode support being implemented throughout layout; but the layout of the table as a whole (columns and rows) also needs to be handled. This may be deferred to a later milestone than the initial release of vertical support for "simple" content.
Comment 1•10 years ago
|
||
Layout of content of table cells in vertical writing-mode
---------------------------------------------------------
table-cell and 'vertical-rl' - block flow direction of block-level boxes
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-block-flow-direction-011.xht
table-cell and 'vertical-lr' - block flow direction of block-level boxes
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-block-flow-direction-012.xht
Layout of table as a whole: row progression tests
-------------------------------------------------
vertical-rl - table rows progression (basic)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-002.xht
vertical-lr - table rows progression (basic)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-003.xht
vertical-rl - table rows progression and colspan
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-004.xht
vertical-lr - table rows progression and colspan
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-005.xht
vertical-rl - table rows progression and rowspan
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-006.xht
vertical-lr - table rows progression and rowspan
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-007.xht
Those 8 tests all use the same reference file:
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/multicol-count-002-ref.xht
Comment 2•10 years ago
|
||
Layout of content of table cells in vertical writing-mode
---------------------------------------------------------
table-cell and 'vertical-rl' - ordering direction of line boxes
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-line-box-direction-011.xht
table-cell and 'vertical-lr' - ordering direction of line boxes
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-line-box-direction-012.xht
Assignee | ||
Comment 3•10 years ago
|
||
Note that a number of the tests in reftests/writing-mode/ua-style-sheet-* that involve tables currently have their vertical writing-mode portions commented out. We should uncomment these once vertical layout is supported.
Assignee | ||
Updated•10 years ago
|
Blocks: enable-writing-mode-release
Comment 4•10 years ago
|
||
Firefox (4/22/2015 Aurora) seems to have the same bug in tables that Chrome has, namely cell content overflows when children of cells are given a vertical writing-mode.
See https://code.google.com/p/chromium/issues/detail?id=410320 for a description of the bug and testcase showing the error.
Comment 5•9 years ago
|
||
Quick draft test on orthogonal table cell based on latest comments 94 and 95 in bug 145503 and also based on
[CSSWG] Minutes New York F2F 2015-05-19 Part I: Writing Modes: Deferring Orthogonal Table Cells
http://lists.w3.org/Archives/Public/www-style/2015May/0313.html
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s73-orthogonal-table-cell-003.xht
This test is, I guess, okay, acceptable for now; its filename may change in the future.
When I have done more orthogonal table-cell tests and when such orthogonal table-cell tests are more reliable and mature, then I will create another bug report and I will make it blocking this bug 1077521.
Gérard
Comment 6•9 years ago
|
||
(In reply to Tyler Rasmussen from comment #4)
> Firefox (4/22/2015 Aurora) seems to have the same bug in tables that Chrome
> has, namely cell content overflows when children of cells are given a
> vertical writing-mode.
When I have more time, I will create tests based on your description. This whole thing is still *very tricky* as
- browsers have quirks and many bugs on table cell rendering
- overflow applies to non-replaced table cells, including overflow: visible
Comment 7•9 years ago
|
||
(In reply to Gérard Talbot from comment #6)
> (In reply to Tyler Rasmussen from comment #4)
> > Firefox (4/22/2015 Aurora) seems to have the same bug in tables that Chrome
> > has, namely cell content overflows when children of cells are given a
> > vertical writing-mode.
>
> When I have more time, I will create tests based on your description. This
> whole thing is still *very tricky* as
> - browsers have quirks and many bugs on table cell rendering
> - overflow applies to non-replaced table cells, including overflow: visible
This issue is in bug 1166120.
Comment 8•9 years ago
|
||
Yes. This
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s73-orthogonal-table-cell-003.xht
test most likely deserves to be available too for bug 1166120
Comment 9•9 years ago
|
||
Just for your information. These 2 tests
table-cell and 'vertical-rl' - ordering direction of line boxes
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-line-box-direction-011.xht
table-cell and 'vertical-lr' - ordering direction of line boxes
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-line-box-direction-012.xht
now pass in Firefox latest nightly build (41.0a1 buildID = 20150622052959).
Gérard
Assignee | ||
Comment 10•9 years ago
|
||
Maybe it's time to do this... table support is some way from complete yet, but I think there's enough of it that we can usefully turn it on and start adding tests, and we don't need this "protecting" us any longer.
Attachment #8625462 -
Flags: review?(smontagu)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment 11•9 years ago
|
||
Comment on attachment 8625462 [details] [diff] [review]
Allow tables to use vertical writing modes
Review of attachment 8625462 [details] [diff] [review]:
-----------------------------------------------------------------
Totally!
Attachment #8625462 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 12•9 years ago
|
||
Here are a couple of basic sanity-test reftests for vertical table layout. Obviously there'll be more to come...
Attachment #8625479 -
Flags: review?(smontagu)
Updated•9 years ago
|
Attachment #8625479 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 14•9 years ago
|
||
Attachment #8625499 -
Flags: review?(smontagu)
Assignee | ||
Comment 15•9 years ago
|
||
Assignee | ||
Comment 16•9 years ago
|
||
Pushed the CSS change and initial reftests here, but let's keep the bug open for at least a few more testcase before marking it fixed.
Keywords: leave-open
Updated•9 years ago
|
Attachment #8625498 -
Flags: review?(smontagu) → review+
Comment 17•9 years ago
|
||
I backed out the reftests for failures on at least Android.
https://treeherder.mozilla.org/logviewer.html#?job_id=11033471&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/d854bedb4980
Comment 18•9 years ago
|
||
Assignee | ||
Comment 19•9 years ago
|
||
Assignee | ||
Comment 20•9 years ago
|
||
Updated•9 years ago
|
Attachment #8625499 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 21•9 years ago
|
||
Comment 22•9 years ago
|
||
Comment 23•6 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:jfkthame, maybe it's time to close this bug?
Flags: needinfo?(jfkthame)
Assignee | ||
Comment 24•6 years ago
|
||
I guess we can close this, as the feature is basically working; and make the remaining open dependencies here directly block the main writing-mode meta bug.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: needinfo?(jfkthame)
Resolution: --- → FIXED
Updated•6 years ago
|
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•