Closed
Bug 1159582
Opened 9 years ago
Closed 9 years ago
All api responses have unnecessary 'result'
Categories
(Bugzilla :: WebService, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: glob, Assigned: glob)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
wicked
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
wicked
:
review+
|
Details | Diff | Splinter Review |
currently we return:
> {
> "result" : {
> "users" : [
> {
> "name" : "tara@bluemartini.com",
> "real_name" : "Tara Hernandez"
> }
> ]
> }
> }
we should be returning:
> {
> "users" : [
> {
> "name" : "tara@bluemartini.com",
> "real_name" : "Tara Hernandez"
> }
> ]
> }
this is caused by an error in the 'fix on commit' change in bug 1152319:
> if (!ref($result)
> || blessed($result)
> || ref($result) ne 'HASH'
> || ref($result) ne 'ARRAY')
> {
this always evaluates to true.
Attachment #8599106 -
Flags: review?(dkl)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8599106 [details] [diff] [review]
1159582_1.patch
Oops. :) The fix seems logical.
Attachment #8599106 -
Flags: review?(dkl) → review+
|
|
||
Updated•9 years ago
|
Attachment #8599126 -
Flags: review?(dkl) → review+
|
|
||
Updated•9 years ago
|
Flags: approval?
Flags: approval5.0?
Summary: all api responses have unnecessary 'result' → All api responses have unnecessary 'result'
Version: unspecified → 5.0
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
3f29df2..27398a7 master -> master
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
bfd649a..a75e069 5.0 -> 5.0
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: approval?
Flags: approval5.0?
Flags: approval5.0+
Flags: approval+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•