Closed Bug 1159589 Opened 9 years ago Closed 9 years ago

migrate autocomplete from yui to jquery

Categories

(Bugzilla :: User Interface, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 6.0

People

(Reporter: glob, Assigned: glob)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

we need to migrate autocomplete from yui to jquery.
Depends on: 1159582
Attached patch 1159589_1.patch (obsolete) (deleted) — Splinter Review
- replace yui with jquery in js/fields.js - implement user autocompletion - implement keyword and bug tag autocompletion - stop using include yui autocomplete resources in a lot of templates note: comment tagging still uses yui's autocompletion, that's a lot more work which i've shifted to bug 1159596
Attachment #8599122 - Flags: review?(dylan)
Attached patch 1159589_2.patch (deleted) — Splinter Review
i realised it would be better to move comment-tagging's autocompletion here, and deal with the rest of the jquery migration in bug 1159596. - replace yui with jquery in js/fields.js - implement user autocompletion - implement keyword and bug tag autocompletion - implement comment tagging autocompletion - remove support for yui autocomplete from global header - stop using include yui autocomplete resources in all of templates
Attachment #8599122 - Attachment is obsolete: true
Attachment #8599122 - Flags: review?(dylan)
Attachment #8599159 - Flags: review?(dylan)
Blocks: 1146782
Comment on attachment 8599159 [details] [diff] [review] 1159589_2.patch Review of attachment 8599159 [details] [diff] [review]: ----------------------------------------------------------------- It looks like this has bit-rotted?
Attachment #8599159 - Flags: review?(dylan)
No, I'm just an idiot that did "bz new 1159589" without saying that this was on *upstream* and not BMO.
Attachment #8599159 - Flags: review?(dylan)
Comment on attachment 8599159 [details] [diff] [review] 1159589_2.patch Review of attachment 8599159 [details] [diff] [review]: ----------------------------------------------------------------- r=dylan but fix the trailing comma on commit ::: js/comment-tagging.js @@ +38,5 @@ > + serviceUrl: function(query) { > + return 'rest/bug/comment/tags/' + encodeURIComponent(query); > + }, > + params: { > + Bugzilla_api_token: BUGZILLA.api_token, nit: trailing comma
Attachment #8599159 - Flags: review?(dylan) → review+
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git 7a75256..33a4bd4 master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: approval+
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 6.0
Blocks: 1163393
Blocks: 1163399
Blocks: 1168439
Blocks: 1210078
Blocks: 1247195
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: