2001121803 / Windows 95 Make sure the sidebar is showing, but collapsed. Press F9 twice, to fully hide, then re-show the sidebar. The sidebar re-appears open, but with most of the content hidden as if it was collapsed.

morse, please r. alecf, please sr. This bug also happens to fix bug 70126. I'll close it out at when I check this in.

+ if (sidebar_splitter.getAttribute('state') == 'collapsed') + sidebar_splitter.removeAttribute('state'); Is this just defensive coding or is there a case in which the attribute actually does get set to "collapsed"? If so, where is that coming from and can't we fix the code that is doing the setting?

This isn't defensive coding: the way we retain collapsed state is by setting the "state" attribute on the splitter. We toggle this with the common technique of removing the attribute instead of setting it to something like "shown". When toglling the sidebar between collapsed and expanded we already toggle this attrubute by setting and removing it. This case is when we *unhide* a collapsed sidebar in which case we don't want only show the splitter, we want to expand the sidebar as well: i.e., overall effect of unhide == unhide + expand. Hence the additional "state" attribute removal.

Comment on attachment 62300 [details] [diff] [review] Remove state="collapsed" attr from sidebar-splitter. ok, I'm satisfied. r=morse

Comment on attachment 62300 [details] [diff] [review] Remove state="collapsed" attr from sidebar-splitter. sr=alecf

any chance this can get checked in?

I see the sidebar contents come back after hitting F9 twice.. see attachment 64655 [details] and bug 116094

Here is another weird sidebar thing in Mail/News, the whole sidebar issue I have is it is doing weird things, which I may just file a new bug about it once I write all them down. It contents are displayed differently depending on where the grippy line is for cases of opening mail/news, hitting F9 twice while in mail/news, or having sidebar showing vs hidden.

*** Bug 119613 has been marked as a duplicate of this bug. ***

*** Bug 120758 has been marked as a duplicate of this bug. ***

see possible testcase of the weird Mail/News sidebar problems here: bug 121340

*** Bug 121340 has been marked as a duplicate of this bug. ***

Checked in.

see bug 122027 for new problem in build 1-26-08

*** Bug 122390 has been marked as a duplicate of this bug. ***

Kirun, this should be working now..please re-test and let me know...I'll also test on my end...