Closed
Bug 1164623
Opened 10 years ago
Closed 10 years ago
use standard TC environment variable parameters for desktop/android builds
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
References
Details
Attachments
(1 file, 1 obsolete file)
The desktop/android build scripts have a nice set of input variables:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2ce42ea552a#l3.9
but those differ in spelling, etc. from variables typically used for B2G builds. We should resolve those differences to avoid confusion.
Assignee | ||
Comment 1•10 years ago
|
||
Also cache locations; see testing/taskcluster/tasks/builds/*.yml
For example:
tooltool-cache: '/home/worker/tools/tooltool-cache
Assignee | ||
Comment 2•10 years ago
|
||
Cache locations shouldn't be specified in the task, so that's not necessary.
However, B2G seems to use
MOZHARNESS_REPOSITORY: '{{mozharness_repository}}'
MOZHARNESS_REV: '{{mozharness_rev}}'
MOZHARNESS_REF: '{{mozharness_ref}}'
while the desktop script uses
MOZHARNESS_BASE_REPOSITORY: '{{mozharness_repository}}'
MOZHARNESS_HEAD_REPOSITORY: '{{mozharness_repository}}'
MOZHARNESS_REV: '{{mozharness_rev}}'
and similarly
GECKO_HEAD_REV: '{{head_rev}}'
GECKO_HEAD_REF: '{{head_ref}}'
vs
GECKO_REV: '{{head_rev}}'
B2G uses "MOZCONFIG", but that's irrelevant for us since mozharness specifies the mozconfig.
Assignee | ||
Comment 3•10 years ago
|
||
/r/9455 - Bug 1164623: align env variable names with B2G; r=mrrrgn
Pull down this commit:
hg pull -r 42aaec27266eae2bf2a502e648687036697109ab https://reviewboard-hg.mozilla.org/gecko/
Attachment #8611354 -
Flags: review?(winter2718)
Comment 4•10 years ago
|
||
https://reviewboard.mozilla.org/r/9455/#review8205
::: testing/docker/desktop-build/bin/build.sh
(Diff revision 1)
> -: TOOLS_BASE_REPOSITORY ${TOOLS_BASE_REPOSITORY:=https://hg.mozilla.org/build/tools}
Ahh, nice! Inheriting these is much cleaner.
Updated•10 years ago
|
Attachment #8611354 -
Flags: review?(winter2718) → review+
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8611354 -
Attachment is obsolete: true
Attachment #8620289 -
Flags: review+
Assignee | ||
Comment 8•9 years ago
|
||
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•