Closed
Bug 1164845
Opened 9 years ago
Closed 9 years ago
Retrieve the oauth keys direct from the DB instead of credentials.json
Categories
(Tree Management :: Treeherder: Data Ingestion, defect, P3)
Tree Management
Treeherder: Data Ingestion
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: emorley, Unassigned)
References
Details
With current stage/production, we have a deploy step that exports the oauth keys from the datasource table and saves them to a credentials file. This file is then accessed by the ETL nodes when they post to the API using treeherder-client.
With Heroku, we can't use secret files like this, and so in the PR in bug 1145606, support was added for reading in the credentials from the env variable.
The problem with this is that we will have to manually keep this env var up to date for each of stage/prod - so each time we add/delete a repo, it will require additional steps on deploy.
As such, I think we should just ditch this external credentials file/env var concept, and allow the ETL nodes to just fetch the credentials directly from the datasource table. (All nodes on Heroku have access to the DB anyway aiui, so this shouldn't be a problem from a flow point of view).
Reporter | ||
Updated•9 years ago
|
Summary: Make the ETL nodes retrieve the oauth keys direct from the DB → Retrieve the oauth keys direct from the DB instead of credentials.json
Reporter | ||
Updated•9 years ago
|
Priority: P2 → P3
Reporter | ||
Updated•9 years ago
|
No longer blocks: treeherder-heroku-prototype
Reporter | ||
Updated•9 years ago
|
Blocks: treeherder-heroku
Comment 1•9 years ago
|
||
This bug could be invalidated by bug 1160111 and bug 1043334. I'll mark them as dependencies to avoid wasting effort on this until those are solved.
Comment 2•9 years ago
|
||
bug 1209555 made this invalid
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Reporter | ||
Updated•9 years ago
|
Resolution: INVALID → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•