Andrew Halberstadt [:ahal] Assignee
	Description • 9 years ago

It turns out passing in an argument to every unittest job on a given builder is actually quite complicated. I'm just going to compare the stage_platform buildbot property to a list of known platforms that should have code coverage enabled. This is slightly hacky, but easy to do (and otherwise code coverage would block indefinitely yet again).

	Andrew Halberstadt [:ahal] Assignee
	Comment 1 • 9 years ago

/r/8819 - Bug 1164967 - Enable code coverage for all unittests running on the linux64-cc platform, r=jgriffin

Pull down this commit:

hg pull -r fffcb0785ca52d5320ff9c0df4c0d4c2bbd5abb4 https://reviewboard-hg.mozilla.org/build-mozharness

	Andrew Halberstadt [:ahal] Assignee
	Comment 2 • 9 years ago

Here's a working try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4f11b4b3636

	Jonathan Griffin (:jgriffin)
	Comment 3 • 9 years ago

Comment on attachment 8606273 [details]
MozReview Request: bz://1164967/ahal

https://reviewboard.mozilla.org/r/8817/#review7517

lgtm!

	Andrew Halberstadt [:ahal] Assignee
	Comment 4 • 9 years ago

Comment on attachment 8606273 [details]
MozReview Request: bz://1164967/ahal

https://hg.mozilla.org/build/mozharness/rev/5169f4f6b80f

	Release Engineering SlaveAPI Service
	Comment 5 • 9 years ago

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/production

	Release Engineering SlaveAPI Service
	Comment 6 • 9 years ago

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/production

	Andrew Halberstadt [:ahal] Assignee
	Comment 7 • 9 years ago

Checking for the code coverage platforms can also raise TypeError if self.buildbot_configs is None. This doesn't seem to happen in automation, but a developer hit it while running mozharness locally, so landed a minor follow-up fix:
https://hg.mozilla.org/build/mozharness/rev/5d3fd29f9793

	Andrew Halberstadt [:ahal] Assignee
	Comment 8 • 9 years ago

Mozharness version bump was recently landed on central.