Closed Bug 1166984 Opened 9 years ago Closed 9 years ago

I think Taskcluster jobs' "Inspect Task" link should still be in the left panel, not the Job Details tab

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: KWierso, Assigned: jfrench)

References

Details

Attachments

(1 file)

(deleted), text/x-github-pull-request
wlach
: review+
Details
I think it should stay in the left pane, closer (and without needing any unnecessary extra clicks) to the buttons for the logviewer links.
If other Sheriffs are in agreement, should we also the default height of the main job panel slightly taller(?), so this added Inspect Task entry isn't clipped off the bottom of the bottom left pane (and then requires equivalent effort to view it). I believe in some cases this change will also result in an empty Job Details tab, where afaik currently we always had something populating it. So we may need to add a "Job Details empty" tab message or similar.
Flags: needinfo?(ryanvm)
Flags: needinfo?(cbook)
I think we need to be careful about just polling the sheriffs on this-- we added the job details panel because the stuff on the left side wasn't discoverable enough to other users of treeherder. I'm fine with just including the information in two different places fwiw. I don't think that hurts.
Couple of options perhaps: a) conditionally provide a 'task' icon in the navbar eg. beside the current Log icon, if the job is a taskcluster job? The navbar UI might bounce around a lot though when traversing buildbot and tc jobs. b) perhaps a more minimal "task" text link in the bottom left details, similar and adjacent to our 'sig'-nature link. So we don't consume another full line.
Flags: needinfo?(ryanvm)
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
Flags: needinfo?(cbook)
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
I think we'll go with a regular line entry below the Log parsing status for now in Job details panel. Based on discussions with Wes, sheriffs run at sufficient screen res systems the default 35% height for info panel will accommodate the extra line.
Attached file PR 755 (deleted) —
Please see above PR for status/review.
Attachment #8633475 - Flags: review?(wlachance)
Comment on attachment 8633475 [details] PR 755 lgtm
Attachment #8633475 - Flags: review?(wlachance) → review+
Marking fixed per above merge. Will verify on the next push to stage/prod.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fixed on stage.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: