Closed
Bug 1167446
Opened 9 years ago
Closed 4 years ago
Consolidate magnifying glass icons
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: mcomella, Unassigned, Mentored)
References
Details
(Whiteboard: [lang=java])
We have:
* search_icon_active (i.e. this one is darker though - can use a filter)
* search_icon_inactive
* favicon_search
* ic_widget_search
* ab_search
* suggestion_item_search
And Anthony is giving me another one to add in bug 1166868.
We should try scaling these (caveat being some of these may have whitespace in the drawables).
Reporter | ||
Comment 1•9 years ago
|
||
suggestion_item_search may be removed when bug 1158275 lands, which shouldn't be too far off.
Reporter | ||
Updated•9 years ago
|
Mentor: michael.l.comella, mhaigh
Whiteboard: [lang=java]
Reporter | ||
Comment 2•9 years ago
|
||
In places where icons have whitespace in the drawables, consider using inset drawables to replace the whitespace.
Comment 3•9 years ago
|
||
I tinted search_icon_active successfully using DrawableCompat.setTint() in bug 1172071. Hopefully we can apply that all other occurrences of search_icon_inactive.
Reporter | ||
Comment 4•9 years ago
|
||
I'm writing a utility method in bug 1189585, `DrawableUtil.tintDrawable` to simplify this process.
Reporter | ||
Updated•9 years ago
|
Blocks: clean-drawables
Comment 5•4 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Assignee | ||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•