Closed Bug 1189585 Opened 9 years ago Closed 9 years ago

Create DrawableUtil.tintDrawable

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(2 files)

MozReview Request: Bug 1189585 - Add DrawableUtil class. r=sebastian
(deleted), text/x-review-board-request
sebastian
: review+
Details
MozReview Request: Bug 1189585 - Change SearchEngineBar to use the DrawableUtil class. r=sebastian
(deleted), text/x-review-board-request
sebastian
: review+
Details
Bug 1189585 - Add DrawableUtil class. r=sebastian This includes a method to tint drawables.
Attachment #8641419 - Flags: review?(s.kaspari)
Comment on attachment 8641419 [details] MozReview Request: Bug 1189585 - Add DrawableUtil class. r=sebastian Bug 1189585 - Add DrawableUtil class. r=sebastian This includes a method to tint drawables.
Comment on attachment 8641420 [details] MozReview Request: Bug 1189585 - Change SearchEngineBar to use the DrawableUtil class. r=sebastian Bug 1189585 - Change SearchEngineBar to use the DrawableUtil class. r=sebastian
Comment on attachment 8641419 [details] MozReview Request: Bug 1189585 - Add DrawableUtil class. r=sebastian https://reviewboard.mozilla.org/r/14517/#review13125 That's super nice! :) I wish we would have support annotations[1] so that we can guarantee (in the IDE..) that the values passed in are actually drawables or colors. Otherwise it's easy to mix them up or pass in something like 0xFF0000 as color. [1] http://tools.android.com/tech-docs/support-annotations (Resource Type Annotations)
Attachment #8641419 - Flags: review?(s.kaspari) → review+
Comment on attachment 8641420 [details] MozReview Request: Bug 1189585 - Change SearchEngineBar to use the DrawableUtil class. r=sebastian https://reviewboard.mozilla.org/r/14519/#review13127 Ship It!
Attachment #8641420 - Flags: review?(s.kaspari) → review+
Assignee: nobody → michael.l.comella
url: https://hg.mozilla.org/integration/fx-team/rev/431678640625918feadb3eb599e2973257816260 changeset: 431678640625918feadb3eb599e2973257816260 user: Michael Comella <michael.l.comella@gmail.com> date: Thu Jul 30 19:16:41 2015 -0700 description: Bug 1189585 - Add DrawableUtil class. r=sebastian This includes a method to tint drawables. url: https://hg.mozilla.org/integration/fx-team/rev/61e8be8a63d18490809565d31ab8e6e33c70a309 changeset: 61e8be8a63d18490809565d31ab8e6e33c70a309 user: Michael Comella <michael.l.comella@gmail.com> date: Thu Jul 30 18:41:13 2015 -0700 description: Bug 1189585 - Change SearchEngineBar to use the DrawableUtil class. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/431678640625 https://hg.mozilla.org/mozilla-central/rev/61e8be8a63d1
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: