Closed
Bug 1170500
Opened 9 years ago
Closed 9 years ago
[Mac] Broken one-off search items layout
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
Here is a screenshot of the problem: http://cl.ly/image/0L2N1g0Z3r2P
It looks like this has been regressed by bug 459563 / http://hg.mozilla.org/mozilla-central/rev/6d88bce884dc#l5.15
The attached patch makes the Mac CSS be more similar to the Windows one.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → florian
|
||
Updated•9 years ago
|
Attachment #8613993 -
Flags: review+
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8613993 [details] [diff] [review]
Fix
> .search-panel-one-offs {
>+ margin: 0 0 !important;
margin: 0 !important;
|
|
Assignee | |
Comment 3•9 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #1)
> Comment on attachment 8613993 [details] [diff] [review]
> Fix
>
> > .search-panel-one-offs {
> >+ margin: 0 0 !important;
>
> margin: 0 !important;
This is a good simplification in general, but in this specific case I care more about making the Mac CSS be closer to the Windows/Linux ones, so that we have an easier time de-duplicating (when finishing attachment 8530892 [details] [diff] [review]).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
|
|
Assignee | |
Comment 7•9 years ago
|
||
Hopefully we'll add a test to prevent further regressions like this one in bug 1107178.
You need to log in
before you can comment on or make changes to this bug.
Description
•