STR: 1. Type a long query in the search bar until there are no suggestions. 2. Delete it all, and start typing something. 3. No more suggestions! This regression is reproducible in Nightly, but has not made it to aurora or beta yet.

sorry spam

[Tracking Requested - why for this release]: serious regression in the primary search UI.

I couldn't reproduce with Nightly 42.0a1 - 20150708030204 and 20150721030212 under Win 7 64-bit with Google and Yahoo set as default search engines. What search engine were you using? Is it still reproducible for you? Thank you!

Weird, I can't reproduce it in an official nightly build, but can reproduce in my local build.

I can reproduce on an official nightly when trying on a retina display. The issue persists when I move the window back to my external screen. adw and I were messing with the size of the searchbar and found that increasing its size makes suggestions appear again, but the popup doesn't expand correctly and only 1 and a half suggestions are visible. Seems like a weird popup issue...

FYI I'm testing on a Macbook Pro (hence the retina display ;)), I can reproduce with Google and Yahoo! (didn't try others).

Thanks for the info, I could reproduce it too on a Macbook Pro retina. Here is the mozilla-central pushlog: Last good revision: 5787d784485e (2015-06-10) First bad revision: bfd82015df48 (2015-06-11) Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5787d784485e&tochange=bfd82015df48 mozilla-inboud: Last good revision: 82322f431ac1 First bad revision: bfd82015df48 Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=82322f431ac1&tochange=bfd82015df48 There are several bugs here that modified the search bar, maybe Bug 1158295 or Bug 1170500 broke this.

Tracking because regression in the primary search UI

Thanks Petruta! Bisected this locally to confirm: The first bad revision is: changeset: 247959:612e73e50be6 user: Florian Quèze <florian@queze.net> date: Tue Jun 02 12:54:21 2015 +0200 summary: Bug 1170500 - [Mac] Broken one-off search items layout. r=Gijs Firefox 41 is affected as well.

(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #10) > Thanks Petruta! Bisected this locally to confirm: > > The first bad revision is: > changeset: 247959:612e73e50be6 > user: Florian Quèze <florian@queze.net> > date: Tue Jun 02 12:54:21 2015 +0200 > summary: Bug 1170500 - [Mac] Broken one-off search items layout. r=Gijs Nope, this revision is indeed bad, but it's just fixing a more obvious brokenness, and if I update my local tree to before bug 459563, this bug was already there. My local bisect points to the first bad revision being https://hg.mozilla.org/mozilla-central/rev/0bb094a070d4 / bug 1108648.

Given that this bug can only be reproduced on retina screens, it could be that the underlying issue is bug 1179234.

I still don't fully understand the reason for this bug, but I suspect a rounding issue somewhere is somehow messing with the sizing of the tree. I have a patch attached in bug 1179234 that fixes this bug by making the margin-bottom of the header at the top of the panel (right above the tree) 2px instead of 1.

Fixed in bug 1179234.

Setting flags to make sure this also gets verified along with bug 1179234.

Verified that search suggestions are displayed again after introducing and then deleting a long query using Firefox 41 beta 2, Developer Edition 42.0a2 and Nightly 43.0a1 both 2015-08-19 under MacBook Pro retina 10.9.5.