Closed
Bug 1174638
Opened 9 years ago
Closed 9 years ago
[notification] Improve usability/performance of Airplane mode icon
Categories
(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)
Firefox OS Graveyard
Gaia::System::Status bar, Utility tray, Notification
ARM
Gonk (Firefox OS)
Tracking
(feature-b2g:2.5+, tracking-b2g:+, b2g-master fixed)
Tracking | Status | |
---|---|---|
b2g-master | --- | fixed |
People
(Reporter: bobby.chien+bugzilla, Assigned: aknow)
References
()
Details
(Keywords: perf, Whiteboard: [perf-wanted])
User Story
Story: Bad response (laggy) when user click icon. Solution: 1. Investigating problem 2. Propose solution to Gaia/Gecko/Gonk 3. Improve usability/performance Reference: - UX Guideline: https://drive.google.com/a/mozilla.com/file/d/0Bx_3KVci6YdOM2dNX1NCUW8wZkU/view
Attachments
(1 file)
Improve bad response on airplane mode icon
Reporter | ||
Updated•9 years ago
|
tracking-b2g:
--- → +
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Updated•9 years ago
|
User Story: (updated)
Summary: Improve usability/performance of Airplane mode icon → [notification] Improve usability/performance of Airplane mode icon
Reporter | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
The observation of togging airplane mode from quick setting (notification tray): off -> on icon color change : white -> dim blue -> blue on -> off icon color change : blue -> white The problem is that when switching off, a transitional state (dim blue) is lacked. That means the icon remains in blue for several seconds and then finally turn into white after the phone finish all the works. It seems to me that it's difficult for the users to make sure whether they indeed click the button because the color doesn't change immediately. I would suggest to introduce a transition state when turning from on to off. That makes it symmetric and leads to a better user feeling. Let me ni UX for the experts' ideas. If the proposal sounds good, what is a good presentation of that transitional state. Which color or ...? The presentation should indicate users that it's toggling now and prevent them click the icon again during the period.
Flags: needinfo?(tchen)
Comment 2•9 years ago
|
||
Eric worked on the quick settings. I'm sure his thought will be valuable here.
Flags: needinfo?(epang)
Comment 3•9 years ago
|
||
After I discussed with our designers, I found we have similar issue in the Settings app and we already have a solution for it. If you open the settings app and switch the airplane mode, it will apply a 50% transparency and disable the button during the period. So, actually there is no dedicate color for transition mode, it changes based on original color and background color. I think we can make things consistent here. Proposal: off -> on icon color change : white -> white + 50%transparency -> blue (icon is disable during the period) on -> off icon color change : blue -> blue + 50%transparency -> white (icon is disable during the period)
Flags: needinfo?(tchen)
Assignee | ||
Comment 4•9 years ago
|
||
I guess we might only need to adjust the style here https://github.com/mozilla-b2g/gaia/blob/master/apps/system/style/quick_settings/quick_settings.css Add the color setting for these two rules. #quick-settings-airplane-mode[data-enabling] #quick-settings-airplane-mode[data-disabling] However, I am not familiar with gaia code and the patch process. I'd like to have someone to help and take the bug. Fred, could you help this bug since you know more about the settings?
Assignee: szchen → nobody
Flags: needinfo?(gasolin)
Comment 5•9 years ago
|
||
per offline discussion, add white(#fff) with 50% transparency for [data-disabling] state could change all icons disabling state.
Flags: needinfo?(gasolin)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → szchen
Assignee | ||
Comment 6•9 years ago
|
||
confirmed with UX, the policy should be off -> on: white -> blue (50%) > blue on -> off: blue -> white (50%) -> white
Reporter | ||
Updated•9 years ago
|
feature-b2g: --- → 2.5+
Target Milestone: --- → FxOS-S5 (21Aug)
Assignee | ||
Comment 8•9 years ago
|
||
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8643546 [details]
PR 31251
:gmarty,
Would you please review my pull request?
Per discussion with UX team, we would like to introduce a transient state and the icon color change when switching off airplane mode from quick setting. It could serves as good hit state to indicate the user that the icon is clicked.
Attachment #8643546 -
Flags: review?(gmarty)
Comment 10•9 years ago
|
||
Comment on attachment 8643546 [details]
PR 31251
LGTM. Many thanks!
Attachment #8643546 -
Flags: review?(gmarty) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Keywords: autoland,
checkin-needed
Comment 11•9 years ago
|
||
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Comment 12•9 years ago
|
||
merged to master https://github.com/mozilla-b2g/gaia/commit/497fe3f938722b0aa49c93f975fad5d9ed3b0a82
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
status-b2g-master:
--- → fixed
Keywords: checkin-needed
Reporter | ||
Updated•9 years ago
|
Updated•7 years ago
|
Flags: needinfo?(epang)
You need to log in
before you can comment on or make changes to this bug.
Description
•