Closed Bug 1175254 Opened 9 years ago Closed 9 years ago

Sony msm8226: tianchi and flamingo devices

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

Product:
Firefox OS Graveyard
Component:
GonkIntegration
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: afarden, Assigned: afarden)

References

Details

Attachments

(6 files, 1 obsolete file)

B2G config
(deleted), text/x-github-pull-request
gerard-majax
: review+
Details
Manifest for all devices
(deleted), text/x-github-pull-request
gerard-majax
: review+
Details
Kernel defconfig updates
(deleted), text/x-github-pull-request
gerard-majax
: review+
Details
Yukon (platform) PR
(deleted), text/x-github-pull-request
gerard-majax
: review+
Details
Tianchi (device) PR
(deleted), text/x-github-pull-request
gerard-majax
: review+
Details
Flamingo (device) PR
(deleted), text/x-github-pull-request
gerard-majax
: review+
Details
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.81 Safari/537.36 Steps to reproduce: All Sony devices supported in AOSP work on B2G, so why stop at leo/aries, lets bring some more in!
Attached file B2G config (deleted) —
Attached file Manifest for all devices (deleted) —
Depends on: 1163550
Depends on: 1136032
No longer depends on: 1136032
I updated the two PRs with the new branch names and dropped the dependency on SELinux. We can update all Sony devices at the same time once it is complete.
Depends on: 1177993
Manifest updated, no need for libhardware fork once NFC HAL is renamed
Attached file shinano rename nfc (obsolete) (deleted) —
Attachment #8626903 - Attachment is obsolete: true
Attached file Kernel defconfig updates (deleted) —
Assignee: nobody → adam
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
I'll drop seagull and eagle for now, the former doesn't have working RIL, the latter I don't have to test it personally. Just forks of these: https://github.com/sonyxperiadev/device-sony-yukon https://github.com/sonyxperiadev/device-sony-tianchi https://github.com/sonyxperiadev/device-sony-flamingo
Summary: Sony msm8226: tianchi, seagull, eagle and flamingo → Sony msm8226: tianchi and flamingo devices
(In reply to Adam Farden from comment #9) > I'll drop seagull and eagle for now, the former doesn't have working RIL, > the latter I don't have to test it personally. > > Just forks of these: > > https://github.com/sonyxperiadev/device-sony-yukon > https://github.com/sonyxperiadev/device-sony-tianchi > https://github.com/sonyxperiadev/device-sony-flamingo Forked on mozilla-b2g account.
Flags: needinfo?(adam)
Great! now I just need sony-aosp-l branches made from master on all three repos, then I'll be ready to make a PR.
Flags: needinfo?(adam) → needinfo?(lissyx+mozillians)
Should be good.
Flags: needinfo?(lissyx+mozillians) → needinfo?(adam)
Attached file Yukon (platform) PR (deleted) —
Flags: needinfo?(adam)
Attached file Tianchi (device) PR (deleted) —
Attached file Flamingo (device) PR (deleted) —
Attachment #8623254 - Flags: review?(lissyx+mozillians)
Attachment #8623256 - Flags: review?(lissyx+mozillians)
Attachment #8631155 - Flags: review?(lissyx+mozillians)
Attachment #8635145 - Flags: review?(lissyx+mozillians)
Attachment #8635146 - Flags: review?(lissyx+mozillians)
Attachment #8635150 - Flags: review?(lissyx+mozillians)
Attachment #8631155 - Flags: review?(lissyx+mozillians) → review+
Comment on attachment 8635145 [details] Yukon (platform) PR Left a few comments.
Attachment #8635145 - Flags: review?(lissyx+mozillians)
We really need to fix bug 1176287 to stop copy/pasting the TimeKeep XPCOM everywhere.
Depends on: 1176287
Attachment #8623254 - Flags: review?(lissyx+mozillians) → review+
Comment on attachment 8623256 [details] Manifest for all devices Given that we rely on the AOSP Sony, shouldn't we be able to share stuff between shinano-l and yukon-l ?
Flags: needinfo?(adam)
Attachment #8623256 - Flags: review?(lissyx+mozillians)
Comment on attachment 8635146 [details] Tianchi (device) PR Looks good but why do we have fstab of yukon on this repo ? Left a couple of comments too.
Attachment #8635146 - Flags: review?(lissyx+mozillians) → review+
Attachment #8635150 - Flags: review?(lissyx+mozillians) → review+
fstab is per device because seagull and eagle have /persist and /firmware partitions.
Adam, do you mind making sure your PRs are uptodate ?
all PRs updated, looks good to me.
Flags: needinfo?(adam)
Depends on: 1187474
Attachment #8635145 - Flags: review?(lissyx+mozillians)
Attachment #8623256 - Flags: review?(lissyx+mozillians)
Attachment #8623256 - Flags: review?(lissyx+mozillians) → review+
Looks overall good except a bug in extract-files.sh regarding vendor .mk testing. Also, this should wait until we fix bug 1188325 and the B2G/ PR will need to be rebased (and simplified :))
Depends on: 1188325
Flags: needinfo?(adam)
Comment on attachment 8635145 [details] Yukon (platform) PR You need to fix https://github.com/mozilla-b2g/device-sony-shinano/pull/10 the same way we did :(
Attachment #8635145 - Flags: review?(lissyx+mozillians)
Flags: needinfo?(adam)
Attachment #8635145 - Flags: review?(lissyx+mozillians)
Attachment #8635145 - Flags: review?(lissyx+mozillians) → review+
Ok, fixing bug 1188325 is going to take more time than I expected. I'll land this first.
No longer depends on: 1188325
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: