38.0.1, If [Gmail]/Trash is hidden at Gmail or unsubscribed by user, Trash flag of all folders is cleared, so no folder has "trash can icon", then "delete mail with move to trash model" silently skips "copy to trash" step and simply storess \Deleted flag
Categories
(MailNews Core :: Networking: IMAP, defect)
Tracking
(thunderbird_esr6869+ fixed, thunderbird70 fixed)
People
(Reporter: kees.middelburg, Assigned: gds)
References
(Depends on 1 open bug)
Details
(Keywords: regression, Whiteboard: [regression:Tb38][key comnment 67])
User Story
[Steps to Reproduce], based on Benjamin's description/explanation about phenomenon/problem. 0. Setups Gmail's Label setting (Display Language=English(US) case) : Trash : 'Shown in IMAP' = UNTICKED in gmail settings => [Gmail]/Trash is not returned to any of XLIST, LIST, LSUB Because [Gmail]/Trash is hidden by Gmail, setting of "Show only subscribed folders" is irrelevant to issue. If "Unsubscribe [Gmail]/Trash", [Gmail]/Trash is returned to XLIST, LIST, and [Gmail]/Trash is not returned to LSUB. So, "Show only subscribed folders" is needed. IMAP delete model = Move to trash mail.server.server#.trash_folder_name = AAA View/Folders/All, No automatic new mail check. Before termination of Tb, select account at folder pane, in order to avoid automatic folder open(server access). 1. Restart Tb, Open Inbox => Trash attribute is not set in any folder, so no folder has "trash can icon". 2. Collapse/Expand Gmail IMAP account at Folder Pane "trash can icon" is shown for top level AAA folder at folder pane, then the "trash can icon" of AAA folder quickly disappears. => No folder has Trash attribute, no folder has "trash can icon" 3. Store Trash atrribute in top level BBB folder by my test addon => "trash can icon" is shown for the BBB folder. I didn't check delete mail operation, but it should work. 4. Collapse/Expand Gmail IMAP account at Folder Pane => No folder has Trash attribute, no folder has "trash can icon" Note-1: If [Gmail]/Trash is not hidden by user, [Gmail]/Trash exists in Tb, so Trash attribute is stored in [Gmail]/Trash, and "trash can icon" is shown for [Gmail]/Trash, and "[Gmail]/Trash" is used by "Delete mail" as "Move target folder of Delete Mail operation". Note-2: Following is already known phenomenon in other bug(s). If there is no folder of "trash can icon" under IMAP account, "Delete mail with Move to trash model" silently does do "uid store xx +Flags(\Deleted)" only, even though "uid copy(or move) xx trash-in-Tb" fails or impossible where trash-in-Tb here == first founf folder which has Trash attribute. In contrast to it, if local mail folder account(POP3, Local Folders), "trash folder name in Tb" is hard coded as "Trash", and "no trash can icon folder"==no folder named "Trash". So, if "no trash can icon folder", "Delete mail" does do nothing, with no error message nor feedback to user. This is also known phenomenon.
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mkmelin
:
review+
jorgk-bmo
:
feedback+
jorgk-bmo
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
Comment 1•9 years ago
|
||
Reporter | ||
Comment 2•9 years ago
|
||
Comment 3•9 years ago
|
||
Reporter | ||
Comment 4•9 years ago
|
||
Comment 5•9 years ago
|
||
Reporter | ||
Comment 6•9 years ago
|
||
Reporter | ||
Comment 8•9 years ago
|
||
Comment 10•9 years ago
|
||
Comment 11•9 years ago
|
||
Comment 12•9 years ago
|
||
Updated•9 years ago
|
Comment 13•9 years ago
|
||
Comment 14•9 years ago
|
||
Comment 15•9 years ago
|
||
Comment 16•9 years ago
|
||
Comment 17•9 years ago
|
||
Comment 18•9 years ago
|
||
Comment 19•9 years ago
|
||
Comment 20•9 years ago
|
||
Comment 21•9 years ago
|
||
Comment 22•9 years ago
|
||
Comment 23•9 years ago
|
||
Comment 24•9 years ago
|
||
Comment 25•9 years ago
|
||
Comment 26•9 years ago
|
||
Comment 27•9 years ago
|
||
Comment 28•9 years ago
|
||
Comment 29•9 years ago
|
||
Comment 30•9 years ago
|
||
Comment 31•9 years ago
|
||
Comment 32•9 years ago
|
||
Comment 33•9 years ago
|
||
Comment 34•9 years ago
|
||
Comment 35•9 years ago
|
||
Comment 36•9 years ago
|
||
Comment 37•9 years ago
|
||
Updated•9 years ago
|
Comment 38•9 years ago
|
||
Comment 39•9 years ago
|
||
Comment 40•9 years ago
|
||
Comment 41•9 years ago
|
||
Comment 42•9 years ago
|
||
Comment 43•9 years ago
|
||
Comment 44•9 years ago
|
||
Updated•9 years ago
|
Comment 45•9 years ago
|
||
Updated•9 years ago
|
Comment 46•9 years ago
|
||
Updated•9 years ago
|
Updated•9 years ago
|
Comment 47•9 years ago
|
||
Comment 48•9 years ago
|
||
Comment 49•9 years ago
|
||
Updated•9 years ago
|
Updated•9 years ago
|
Comment 50•9 years ago
|
||
Comment 51•9 years ago
|
||
Comment 52•9 years ago
|
||
Updated•9 years ago
|
Updated•9 years ago
|
Comment 53•9 years ago
|
||
Comment 54•9 years ago
|
||
Comment 55•9 years ago
|
||
Comment 56•9 years ago
|
||
Comment 57•9 years ago
|
||
Comment 58•9 years ago
|
||
Updated•9 years ago
|
Comment 59•9 years ago
|
||
Comment 60•9 years ago
|
||
Comment 61•9 years ago
|
||
Updated•9 years ago
|
Comment 62•9 years ago
|
||
Comment 63•9 years ago
|
||
Comment 64•9 years ago
|
||
Comment 65•9 years ago
|
||
Comment 66•9 years ago
|
||
Updated•9 years ago
|
Updated•9 years ago
|
Comment 67•9 years ago
|
||
Comment 68•8 years ago
|
||
Comment 69•8 years ago
|
||
Comment 70•8 years ago
|
||
Comment 71•8 years ago
|
||
Comment 72•8 years ago
|
||
Comment 75•8 years ago
|
||
Comment 76•8 years ago
|
||
Comment 77•8 years ago
|
||
Comment 78•8 years ago
|
||
Comment 79•8 years ago
|
||
Assignee | ||
Comment 80•5 years ago
|
||
I think since most users just use the default gmail setup that there is no problem with trash folder. At least I haven't seen one.
Comment 81•5 years ago
|
||
But how long do you think you have to work to fix this bad issue?
Assignee | ||
Comment 82•5 years ago
|
||
(In reply to elmhaxx from comment #81)
But how long do you think you have to work to fix this bad issue?
Don't understand your comment.
Not sure from skimming the verbose stuff above what the problem is. If you are interested in this bug, please restate exactly what the problem is, if you don't mind. That would really help. Thanks.
Comment 83•5 years ago
|
||
Is this clear?
... I created a folder named "Deleted" in my Gmail and I used as
folder where to move deleted mails in TB (setting "Move it to this folder:
Deleted on Gmail").From a certain TB version (1-2 years ago, I can't remember) it has started
to not work. The workaround I use after every TB launch is to set "Just
mark ti as deleted" and then set "Move it to this folder: Deleted on Gmail".
In this way the Deleted folder icon in Gmail tree becomes like a trash, and
everything works good (that is when I delete a mail in inbox it's moved into
Deleted folder as expected).Now: is there a TB fix to avoid I have to use this annoying workaround?
Assignee | ||
Comment 84•5 years ago
|
||
(In reply to elmhaxx from comment #83)
Yes, I see that you can set a "non standard" trash name and it works but it reverts back to the standard [Gmail]/Trash folder on tb restart. I think WADA's point is that this is intentional. Also I think 99.9% of users are perfectly happy with the default [Gmail]/Trash being the trash destination. However, you prefer the destination to be [Gmail]/Deleted it seems. Curious why the name "Deleted" instead of "Trash" is important for some users? (Edit: reason sited by many users is because gmail trash deleted in 30 days. Maybe some people just prefer a different name like "RoundFile".)
Gmail's imap (they call it GIMAP) is a very liberal interpretation of the IMAP RFCs and they do things that other more "standard" imap server, like dovecot, don't do like assuming a specific name for Trash and auto-moving (labeling) deleted items to it. (Edit: messages marked deleted are not moved to, actually labeled, Trash by gmail. But they are auto-expunged by default which can be set at gmail site. Tb has to tell gmail to copy mail to Trash folder before setting deleted flag.) So at this point, I'm inclined to vote to close this bug as WONTFIX. (Edit: Well maybe not. Pending further discussion after comment 97.)
Note also that the problem described in comment 83 is considerably different than the original reporter's comment 0 description, which seems to be fixed. (Edit: After looking closer, I think reporter at comment 0 had selected an alternate trash folder name. In that case, it is really the same as comment 83 and bug 533140.)
Comment 85•5 years ago
|
||
Are you saying that if I rename the folder "Deleted" into "Trash" under Gmail, everything in Gmail and TB work good? is this the problem, I created a folder for my emails different than "trash"? how can I know it was the only name TB lets you use..?
Assignee | ||
Comment 86•5 years ago
|
||
(In reply to elmhaxx from comment #85)
Are you saying that if I rename the folder "Deleted" into "Trash" under Gmail, everything in Gmail and TB work good? is this the problem, I created a folder for my emails different than "trash"? how can I know it was the only name TB lets you use..?
I can't swear that will fix it but probably will. Works for me. The reason is because when you set up a gmail account, gmail creates a [Gmail]/Trash folder (or possibly gmail provides a localized name for non-EN locations, not sure) and when tb connects and "lists" the folders, gmail tells tb that [Gmail]/Trash is the designated trash folder so it has the expected icon (and for other reasons). So check on gmail site and make sure you still have the Trash folder there and it is set so it is visible via imap. You can also remove the "Deleted" folder there, I think. Then in tb make sure [Gmail]/Trash is subscribed and visible (a restart may be needed) and set tb so deletes go to [Gmail]/Trash and no longer to "Deleted". If you didn't remove the Deleted folder at gmail site you can delete it via TB now if you want (or rename it to something else or just keep it, doesn't matter).
Note: Or maybe, as you say, you can just rename Deleted to [Gmail]/Trash in tb. Not sure, but I would recommend the procedure I described.
Assignee | ||
Comment 87•5 years ago
|
||
Also, elmhaxx, make sure that the Trash folder is under the gray [Gmail] folder and not outside of it at the same level as INBOX. By default, gmail puts trash under [Gmail] so shouldn't be a problem.
Another consideration is some help sites recommend that you just use "Just mark it as deleted" rather than move to [Gmail]/Trash for the delete method. The rationale can be found here: http://kb.mozillazine.org/Using_Gmail_with_Thunderbird_and_Mozilla_Suite , specifically:
Gmail recommends that you do not use [Gmail]/Trash as your Trash folder since Gmail only keeps a single copy of a message with multiple labels. If you delete a message that way you're also telling it to delete the same message from any other folder (label) that has that message. [12][13] Gmail recommends not making Thunderbird move deleted mail into any folder and instead choose "Just mark it as deleted" from "When I delete a message" in Account Settings -> Server Settings.
This means you still need to have the [Gmail]/Trash folder but the way gmail imap (GIMAP) works is that anything you delete will automatically be put into (actually labeled) with [Gmail]/Trash so you don't need to tell tb to also move the deleted message to [Gmail]/Trash. (I haven't tested this recently but I think it is correct. I use move to trash and don't see problems, but I'm not a gmail on tb power user.)
Edit: I just tested with "just mark as deleted" and it doesn't work the way I expect. So I recommend ignoring the suggestion above. Sorry.
Assignee | ||
Comment 88•5 years ago
|
||
Ok, dependent bug 533140 is basically the same complaint. It brings up a good point that is not mentioned in this bug, or maybe it is but I missed it. A problem with being required (forced actually) to use [Gmail]/Trash is that anything put there is automatically deleted in 30 days. Lots of imap servers do a similar thing for their standard Trash folder but you can always point the tb's trash destination to a another folder that is not subject to auto-deletion.
A suggestion by WADA (bug 533140 comment 40) was to make a code change in the function DiscoveryDone() that, enabled by a new hidden preference, allows tb to treat gmail accounts like non-gmail accounts and respect and keep the user's setting for the trash destination folder. Currently for gmail, when tb starts up and folders are discovered, the gmail LIST response tells tb that [Gmail]/Trash is the trash folder so this overrides the user's selection for trash destination.
I made the suggested change but made it unconditional in my development build and it seems to work OK. I didn't add the hidden pref to enable it. Now I can set any folder of the gmail account to be the trash destination (just like non-gmail servers) and it now remains set on tb restart.
A problem pointed out by WADA is that when the Language setting is changed at the gmail site, this might cause problems. I don't see a problem. I tested it with French, EN-UK and EN-US and the name shown for the trash folder changed from Corbeille to Bin to Trash respectively. I did have to re-set the trash destination to the new name but it didn't seem to be a problem. Also, with any language active, I was still able to set the trash destination to any subscribed folder and it stuck after restart. But maybe I am missing something about this.
With the proposed changed, I also tested a new gmail account creation and the default [Gmail]/[Corbeille || Bin || Trash] folder is still auto-configured as the trash destination.
The attached diff just shows the one-line change I made to test the concept.
Assignee | ||
Updated•5 years ago
|
Comment 89•5 years ago
|
||
Gene, let me understand.. have you fixed the issue? haven't I to try to rename my folder Deleted into Trash as you suggested before?
The reason why I created a folder named "Deleted" was probably because of the already used name "Trash" by Gmail as auto-delete after 30days.. if I remember good, but I could be wrong..
Assignee | ||
Comment 90•5 years ago
|
||
(In reply to elmhaxx from comment #89)
Gene, let me understand.. have you fixed the issue? haven't I to try to rename my folder Deleted into Trash as you suggested before?
The reason why I created a folder named "Deleted" was probably because of the already used name "Trash" by Gmail as auto-delete after 30days.. if I remember good, but I could be wrong..
The "fix" I posted is just a proposal and hoping it might elicit comments from others CC's on this bug without requesting a "need info". But even if everyone says "yes, sound great, do it" it would be months before a the fix is in a beta and possibly even a release. So, if you can live with the 30 day trash life that gmail has, you should go ahead and still do what I recommend: go back to making your "Deleted" folder "[Gmail]/Trash".
Note: There are other workarounds mentioned in bug 533140, like mapping delete key so it archives (moves to All Mail) but none sound too appealing to me.
Comment 91•5 years ago
|
||
My emails can't be deleted after 30 days, I need to keep each one of them.
So I deduce I can't rename "Deleted" into "Trash" if "Trash" has the 30-days auto-purge: right?
(that's why in the beginning I had to create a brand new folder called "Deleted")
Assignee | ||
Comment 92•5 years ago
|
||
(In reply to elmhaxx from comment #91)
My emails can't be deleted after 30 days, I need to keep each one of them.
So I deduce I can't rename "Deleted" into "Trash" if "Trash" has the 30-days auto-purge: right?
(that's why in the beginning I had to create a brand new folder called "Deleted")
That's right. According to gmail their standard "Trash" folder will have its content removed in 30 days. I don't see an option on gmail site to disable this time limit.
There was a lot of interest in this issue 10 years ago when this bug was first entered (Edit: actually bug 533140). Other than you, I'm not sure if there is any interest now. A fairly easy fix was identified in bug 533140 comment 40 that I have tested with Attachment #9080522 [details] [diff] (minus an enabling pref).
Therefore the question to the tb project management is whether this needs to be fixed or not.
Comment 93•5 years ago
|
||
Any valid bug needs to be fixed. Particularly out Gmail support needs to be improved.
Comment 94•5 years ago
|
||
A fairly easy fix was identified in bug 533140 comment 40 that I have tested with Attachment #9080522 [details] [diff] (minus an enabling pref).
Is it a software fix or workaround for users?
Therefore the question to the tb project management is whether this needs to be fixed or not.
Absolutely to be fixed. I'm not the only one, many other friends and users asked me about the solution! In any case, please fix it now or never, after 10 years.. Sure, I can test the bug fix if you need.
Thanks.
Comment 95•5 years ago
|
||
Yeah - gmail doesn't get much love :)
"Trash is hidden at Gmail or unsubscribed by user" is surely an edge case? But IF it's trivial to fix with no downside risk then sure, go for it. If not easy to fix, then should it be given priority above other (gmail) issues is another question. And if it matters whether this is something commonly seen - is better answered by those closer to support, and some who have a better eye for gmail issues (I've cc some).
(Personally, hasn't bothered me, but I don't hold myself up as a typical example - I'm just one.)
Comment 96•5 years ago
|
||
Perhaps a silly question, but why are users doing things like "Trash : 'Shown in IMAP' = UNTICKED in gmail settings" in the first place?
Assignee | ||
Comment 97•5 years ago
|
||
(In reply to Wayne Mery (:wsmwk) from comment #96)
Perhaps a silly question, but why are users doing things like "Trash : 'Shown in IMAP' = UNTICKED in gmail settings" in the first place?
The main concerning with using and showing in imap gmail's trash folder is that the mail put there is deleted after 30 days. I think it is also not in All Mail too after that time. If you could tell tb to put deleted mail in another folder it would stay forever, but you can't permanently do that now. Of course this is a bit confusing since gmail uses labels and doesn't really put things in "folders" that tb shows, but gmail's imap simulates the folders.
The user unsubscribing or disabling for imap the Trash folder at gmail site is not really a problem. The problem is that the user (e.g., elmhaxx) wants to assigned an alternate folder for trash to nullify the 30 day limit. He can set it one time and it works while tb is running. When you restart tb, the setting appears to still be set, but your deleted emails don't go to your designated trash folder, they are just gone. So not really an edge case to want to have deleted emails stick around and not be removed automatically by the email provider.
(In reply to Wayne Mery (:wsmwk) from comment #95)
"Trash is hidden at Gmail or unsubscribed by user" is surely an edge case? But IF it's trivial to fix with no downside risk then sure, go for it. If not easy to fix, then should it be given priority above other (gmail) issues is another question. And if it matters whether this is something commonly seen - is better answered by those closer to support, and some who have a better eye for gmail issues (I've cc some).
I don't think it is really just an edge case. The fix I proposed in the attached diff seems very simple and seems to work for me even when I set gmail site to various languages. However, the problem sited around bug 533140 comment 40 mentions other problems when the user's tb is localized somewhere other than US, which I'm not. I don't completely understand the issues regarding this so that's why I asked for more comments rather than just submitting a formal patch.
Note also that bug 533140 more accurately describes the problem. Bug 533140 comment 40 also sites a possible javascript problem that I don't understand. I don't see it stated but I assume the reporter of this bug, Kees in comment 0, was using an alternate Trash folder too.
I guess if this is as simple as it seems it would have been fixed 10 years ago when Bug 533140 was submitted.
Comment 98•5 years ago
|
||
Gmails 30 day deletion is still confusing to our users. They regularly report issues, not only with gmail, where Thunderbird is set to delete nothing and the trash file keeps emptying itself. I think perhaps we need to rethink deleted as users appear to think deleted is "completed" and the trash is a large completed items folder.
However if a simple fix is available for gmail. Go for it is my feeling.
Assignee | ||
Comment 99•5 years ago
|
||
(In reply to Matt from comment #98)
Gmails 30 day deletion is still confusing to our users. They regularly report issues, not only with gmail, where Thunderbird is set to delete nothing and the trash file keeps emptying itself. I think perhaps we need to rethink deleted as users appear to think deleted is "completed" and the trash is a large completed items folder.
With my proposed fix, another folder name like "RoundFile" can be designated as trash destination. Other than the possible localization issues, one problem with it is that messages deleted to RoundFile will, of course, not be in the gmail's Trash. Therefore when messages are deleted from RoundFile or RoundFile is emptied, the messages will still be in [Gmail]/All Mail and not really gone. Also, if the same message exists in multiple folders, when deleted from one of the folder, the message will remain in all the other folders; however, this may be good and what most users expect. To permanently and completely delete the message, including from All Mail, all copies in multiple folders would need to be moved to gmail's Trash using tb (assuming [Gmail]/Trash is visible via imap and subscribed in tb), or at gmail site, delete the message to Trash in a single folder which will put all copies effectively in Trash. Then delete or empty trash at gmail site; this can't be done in tb (* see below) since [Gmail]/Trash is now not the designated trash folder. So these extra step are needed to completely erase a message from gmail.
Of course, even with my proposed fix, when a gmail account is created in tb, tb will set [Gmail]/Trash as the trash destination initially. I suspect most users are OK with that and will just leave it as is. However, even with this default setting there may be issues other than just the 30 day trash limit. One is that if you have the same message copied to multiple folders and you delete it in any one of the folders, all copies will effectively be moved to Trash. Then when it is deleted from Trash or when Trash is emptied, since it is truly in gmail's Trash, it will completely removed from gmail, including All Mail.
The above is based on doing detailed tests with tb and gmail since I wasn't completely sure how it works. The tb/gmail/imap documentation I could find was not always real clear. The discussion also assumes that the imap setting at the gmail site are default.
(*) A possible way to to still empty [Gmail]/Trash in tb with RoundFile as the designated trash folder is to temporarily set the delete method to "Delete immediately" and then delete the messages copied to [Gmail]/Trash. This should mark them all with imap \deleted and expunge the deleted messages in [Gmail]/Trash so the the messages are completely deleted from gmail, even from All Mail. (I haven't actually tested this.)
Edit: Now I have tested it. A problem is that when the messages in Trash are marked \deleted by tb, and even though gmail site is configured with the default "When I mark a message in IMAP as deleted, auto-expunge on -- immediately update the server" this doesn't seem to apply for Trash. I had to also compact Trash in tb which expunges the Trash folder to remove the messages from Trash folder and from gmail completely. (I noticed also that when a message that exists in one or more folders is moved to Trash, it only exists in Trash and is also now not listed in All Mail.)
Assignee | ||
Comment 100•5 years ago
|
||
Here's a formal patch for review and feedback. All it does treat any user selected folder for any server, including gmail, the same. It has exactly the same effect as my previous attached diff attachment #9080522 [details] [diff] [review] (set obsolete). It allow the user to use any gmail account folder as the trash destination, not just [Gmail]/Trash.
I haven't yet been able to test this with the Trunk version since the build seems to be hanging and not progressing for long periods. All I see now while building is python2.7 in top. When actually building and before hanging I see rust and clang in top, but now just python2.7. On the screen I see this with nothing new for a long time:
:
17:42.88 Compiling hyper v0.12.19
17:53.29 Compiling warp v0.1.16
18:00.25 Compiling webdriver v0.39.0 (/home/gene/mozilla2/testing/webdriver)
18:42.84 Finished dev [optimized + debuginfo] target(s) in 16m 32s
ttER: configure pre-export export compile misc libs tools
compile
is underlined so at compile step.
Edit1: Well, rebooted and build seems to be progressing now. We'll see how it goes...
Edit2: Build finished and patch seems to work.
Comment 101•5 years ago
|
||
Comment 102•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 103•5 years ago
|
||
Thanks Magnus. I want to try to make "try" test build for user elmhaxx (comment 94).
Elmhaxx, it will be en-US localized so I think that's OK.
Assignee | ||
Comment 104•5 years ago
|
||
elmhaxx, Here's a link to a test "try" build with the patch to allow a user specified trash folder to remain in effect after a tb restart. I'm assuming that a 64-bit windows version is OK so here is the link to the installer:
If this is not ok, you can also get a 32-bit version on this page:
Click on the green B next to "Windows 2012 opt" to select the 32-bit build. Then when info comes up at the bottom, click on "Job Details". Then scroll down until you find "target.installer.exe" which you can then download. (Note: Ignore the versions that mention debug. I built them by mistake. They will work but are probably larger and slower since they are not optimized. Also, you can access the 64-bit version installer through this page too.)
When you run this Thunderbird version it will indicate that it is "daily" I think, but my patch will be included even though it is not yet been pushed to daily. Let me how it works for you and feel free to share it with others that you mentioned that have this issue.
Edit: Alternatively, I have done this build with the patch applied to ESR60 release. It may be more "stable" than the daily linked above and may work better with any add-ons you may be using:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&collapsedPushes=525525&revision=70db47cf5670d79ba62a36b4b8b73b0d740c5d5e
I didn't include the "debug" versions this time and left out all the unit tests. Again, just click the "B" beside the desired version and down below under "Job Details" find the link for "target.installer.exe" and download it.
Assignee | ||
Comment 105•5 years ago
|
||
After a bit of delay, commenter/reporter elmhaxx did a test on the "try" version and it solves his problem. Here's what he wrote in a email to me:
I've just tried your TB version and it seems to be good!
I've found the folder (Gmail) "Deleted" already with the right icon
after the TB launch; also deleting mails in (Gmail) inbox moved them
into the folder "Deleted".
Alright: if you haven't other test, when could it be available as
official version?
Thanks.
So, as I expected, the patch solves the problem.
Assignee | ||
Comment 106•5 years ago
|
||
Commenter elmhaxx has again requested status on this via email. So this informs him that I can't commit or land the patch and am waiting on action by Magnus or possibly Jorg.
Comment 107•5 years ago
|
||
If you need something checked in, just set the "checkin-needed" keyword. I'll land it now.
Comment 108•5 years ago
|
||
Comment 109•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b1e49a0013b6
Allow Gmail account to work correctly with a custom Trash folder. r=mkmelin
Comment 110•5 years ago
|
||
Hmm, this has been sitting here inactive since Aug 15th. That's unfortunate, but if you don't request checkin, it might get forgotten. I follow most active bugs, but with 200+ bugmails per day, I can't follow every detail of everything.
Assignee | ||
Comment 111•5 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #108)
Comment on attachment 9081186 [details] [diff] [review]
1175446-review-changes-v0.patchI guess you want this in TB 68 ESR at some stage.
Yes.
I didn't know I needed to "request check in". Always before the reviewer with check-in privilege (you) did the check-in as soon as giving it a +. This is the first time for me the reviewer was someone other than you (Magnus) so I assumed he would do the check-in just like you always did.
Comment 112•5 years ago
|
||
We usually let the patch author set checkin-needed, as he has the best over all picture for the bug he's fixing.
Assignee | ||
Comment 113•5 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #112)
We usually let the patch author set checkin-needed, as he has the best over all picture for the bug he's fixing.
Ok, I'll remember that.
Comment 114•5 years ago
|
||
Comment 115•5 years ago
|
||
TB 68.1.1 or TB 68.2:
https://hg.mozilla.org/releases/comm-esr68/rev/9767acaec457b304aba9c26af5b050b139153814
Merged with bug 1579304.
Assignee | ||
Comment 116•5 years ago
|
||
After installing 68.1.1, received this email from commenter elmhaxx:
On 9/26/19 2:37 AM, elmhaxx wrote:> It works! :)
>
> So.. I have to thank you to have solved an issue none fixed in many years :O
>
> Really, thanks a lot.
Assignee | ||
Updated•3 years ago
|
Description
•