Closed Bug 1178234 Opened 9 years ago Closed 9 years ago

Remove the concept of repository version (eg gecko milestone)

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

(deleted), text/x-github-pull-request
mdoglio
: review+
Details
This is something that is now surfaced via hg.m.o's json API & I don't think is something we should track in Treeherder. To my knowledge it's unused in Treeherder.
Status: NEW → ASSIGNED
Depends on: 1178719
Attached file Remove repository_version (deleted) —
Attachment #8627633 - Flags: review?(mdoglio)
Attachment #8627633 - Flags: review?(mdoglio) → review+
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/6b1e4f602bafa7c8738c1dffe6f211233bfbcc1f Bug 1178234 - Remove repository_version Since it's unused, and hg.mozilla.org now has this information available via its API. Note: This commit depends on bug 1178719, to prevent issues during deployment. Also, due to https://code.djangoproject.com/ticket/25036 a migrate will need to be run interactively after deployment, to clean up the old repositoryversion content type.
[emorley@treeherder-rabbitmq1.stage.private.scl3 ~]$ cd /data/www/treeherder.allizom.org/treeherder-service/ [emorley@treeherder-rabbitmq1.stage.private.scl3 treeherder-service]$ ../venv/bin/python ./manage.py migrate Operations to perform: Synchronize unmigrated apps: corsheaders, rest_framework_swagger, workers, rest_framework, embed, rest_framework_extensions Apply all migrations: sessions, admin, sites, auth, contenttypes, model Synchronizing apps without migrations: Creating tables... Installing custom SQL... Installing indexes... Running migrations: No migrations to apply. The following content types are stale and need to be deleted: model | repositoryversion Any objects related to these content types by a foreign key will also be deleted. Are you sure you want to delete these content types? If you're unsure, answer 'no'. Type 'yes' to continue, or 'no' to cancel: yes [emorley@treeherder-rabbitmq1.stage.private.scl3 treeherder-service]$ ../venv/bin/python ./manage.py dbshell <snip> mysql> SELECT table_schema, table_name FROM information_schema.tables WHERE table_name = 'repository_version'; +------------------+--------------------+ | table_schema | table_name | +------------------+--------------------+ | treeherder_stage | repository_version | +------------------+--------------------+ 1 row in set (0.00 sec) mysql> DROP TABLE treeherder_stage.repository_version; Query OK, 0 rows affected (0.17 sec) mysql> SELECT table_schema, table_name FROM information_schema.tables WHERE table_name = 'repository_version'; Empty set (0.00 sec)
And prod: [emorley@treeherder-rabbitmq1.private.scl3 treeherder-service]$ ../venv/bin/python ./manage.py migrate Operations to perform: Synchronize unmigrated apps: corsheaders, rest_framework_swagger, workers, rest_framework, embed, rest_framework_extensions Apply all migrations: sessions, admin, sites, auth, contenttypes, model Synchronizing apps without migrations: Creating tables... Installing custom SQL... Installing indexes... Running migrations: No migrations to apply. The following content types are stale and need to be deleted: model | repositoryversion Any objects related to these content types by a foreign key will also be deleted. Are you sure you want to delete these content types? If you're unsure, answer 'no'. Type 'yes' to continue, or 'no' to cancel: yes [emorley@treeherder-rabbitmq1.private.scl3 treeherder-service]$ ../venv/bin/python ./manage.py dbshell mysql> DROP TABLE treeherder.repository_version; Query OK, 0 rows affected (0.19 sec) mysql> SELECT table_schema, table_name FROM information_schema.tables WHERE table_name = 'repository_version'; Empty set (0.05 sec)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
[~/src/treeherder]$ heroku run './manage.py migrate' Running `./manage.py migrate` attached to terminal... up, run.5349 Operations to perform: Synchronize unmigrated apps: embed, rest_framework_extensions, workers, corsheaders, rest_framework, rest_framework_swagger Apply all migrations: contenttypes, sites, sessions, auth, admin, model Synchronizing apps without migrations: Creating tables... Installing custom SQL... Installing indexes... Running migrations: No migrations to apply. The following content types are stale and need to be deleted: model | machinenote model | repositoryversion Any objects related to these content types by a foreign key will also be deleted. Are you sure you want to delete these content types? If you're unsure, answer 'no'. Type 'yes' to continue, or 'no' to cancel: yes Run using mysqlworkbench (since dbshell doesn't work on the dynos due to mysql not being on path or present): DROP TABLE treeherder.repository_version;
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: