Closed Bug 1178389 Opened 9 years ago Closed 9 years ago

Remove the parse_timestamp field from the job_log_url table

Categories

(Tree Management :: Treeherder: Data Ingestion, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I think we could possibly remove the parse_timestamp field from job_log_url: `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT, `job_id` bigint(20) unsigned NOT NULL, `name` varchar(50) COLLATE utf8_bin NOT NULL, `url` varchar(255) COLLATE utf8_bin NOT NULL, `parse_status` enum('pending', 'parsed', 'failed') COLLATE utf8_bin DEFAULT 'pending', `parse_timestamp` int(10) NOT NULL, `active_status` enum('active','onhold','deleted') COLLATE utf8_bin DEFAULT 'active', Since iirc we don't actually use it anywhere - and I think logs are better for this.
At some point in the future when we post artifacts to S3, we'll just be storing the URLs to the artifacts and so the schema for the job_artifact table and job_log_url tables will be even similar - and by removing this file even more so.
s/file/field/
Attached file Remove job_log_url.parse_timestamp (deleted) —
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Attachment #8627452 - Flags: review?(cdawson)
Summary: Possibly remove the parse_timestamp field from the job_log_url table → Remove the parse_timestamp field from the job_log_url table
Once this lands & is deployed, I'll do a: manage.py run_sql -s "ALTER TABLE job_log_url DROP COLUMN parse_timestamp;" (according to http://dev.mysql.com/doc/refman/5.1/en/alter-table.html , the index will be automatically removed when I remove the field) ...on stage/prod. Though given the size of the job_log_url table, I may wait to do this at the same time as the job_log_url parts of bug 1178395, since I presume it can remove both columns at the same time.
Attachment #8627452 - Flags: review?(cdawson) → review+
Blocks: 1179011
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: 1181743
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: