Closed Bug 1179153 Opened 9 years ago Closed 9 years ago

location bar shows "search with Google" as the default action even when keyword.enabled is false

Categories

(Firefox :: Address Bar, defect, P2)

Product:
Firefox
Component:
Address Bar
Version:
42 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Iteration:
42.3 - Aug 10
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: Robert.breuil49, Assigned: mak)

References

Details

(Keywords: regression, Whiteboard: [unifiedcomplete bug][fxsearch])

Attachments

(1 file, 1 obsolete file)

patch v1.1
(deleted), patch
mossop
: review+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:42.0) Gecko/20100101 Firefox/42.0 Build ID: 20150630030204 Steps to reproduce: 1. set keyword.enabled to false 2. type gaston into the location bar and unchecked box ... http://getwebb.org/v/qwv4ZLom Verified Safe Mode and New Profile Actual results: actual outcome: - the default action is "gaston" - search with google" ! Expected results: expected outcome: - the default action should be displayed as "gaston" in bookmark or historical !
Component: Untriaged → Location Bar
According to this comment (http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/UnifiedComplete.js#1092) we should show a "visit" entry and not a "search with" entry... So maybe something is wrong in that code assumption.
Blocks: UnifiedComplete
Flags: firefox-backlog+
Priority: -- → P3
Whiteboard: [unifiedcomplete][fxsearch]
Status: UNCONFIRMED → NEW
Ever confirmed: true
not identical bug:1085796 Fx 42 and FX41 only affected by this bug. No bug Fx 40 and Fx 39.
Rank: 23
Keywords: regression
Priority: P3 → P2
Whiteboard: [unifiedcomplete][fxsearch] → [unifiedcomplete bug][fxsearch]
(In reply to Bob49 from comment #3) > not identical bug:1085796 > > Fx 42 and FX41 only affected by this bug. 41 is no more affected, we disabled the feature there.
ok for 41. Users appreciate
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attached patch patch v1 (obsolete) (deleted) — — Splinter Review
Attachment #8637146 - Flags: review?(adw)
Comment on attachment 8637146 [details] [diff] [review] patch v1 rebalancing reviews load
Attachment #8637146 - Flags: review?(adw) → review?(dtownsend)
Attached patch patch v1.1 (deleted) — — Splinter Review
minor unbitrot
Attachment #8637146 - Attachment is obsolete: true
Attachment #8637146 - Flags: review?(dtownsend)
Attachment #8639755 - Flags: review?(dtownsend)
Attachment #8639755 - Flags: review?(dtownsend) → review+
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/5c091530338b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Iteration: --- → 42.3 - Aug 10
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: