Closed
Bug 1179300
Opened 9 years ago
Closed 9 years ago
Disable dynamic UA override updates (and add back the local youtube override)
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox41+ fixed, firefox42 fixed, fennec41+)
RESOLVED
FIXED
Firefox 42
People
(Reporter: miketaylr, Assigned: miketaylr)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Margaret
:
review+
kglazko
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
For some reason ua-update.json isn't doing what it should be doing and Youtube is broken in Nightly and Aurora.
Let's turn it off, fix Youtube and figure out what's going on.
Assignee | ||
Comment 1•9 years ago
|
||
[Tracking Requested - why for this release]:
Requesting tracking because Youtube is broken. That's no good.
Assignee | ||
Comment 2•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 3•9 years ago
|
||
OK, rebuilding with this patch I've cleared data and verified that Youtube works. I even uninstalled a few times and re-installed and it still works.
Updated•9 years ago
|
Attachment #8628328 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Thanks for the quick review Margaret.
Sheriffs, no Try run because we're just changing one pref value and adding an UA override pref to mobile.js. Building locally shows that it works as expected.
Keywords: checkin-needed
Keywords: checkin-needed
Comment 6•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8628328 [details] [diff] [review]
1179300-Disable-dynamic-UA-updates-and-add-local.patch
Approval Request Comment
[Feature/regressing bug #]:
Dyanamic UA overrides, updated from our CDN. Bug 1175305.
[User impact if declined]:
Youtube.com will be broken for Aurora (Mobile) users.
[Describe test coverage new/current, TreeHerder]:
None. Dynamic UA override tests are disabled. Part of re-enabling this feature will be to figure out exactly why.
[Risks and why]:
Little to no risk. Just flipping a pref, and moving a Youtube override from one place (dynamic ua CDN) to another (local pref).
[String/UUID change made/needed]:
None
tracking-fennec: ? → 41+
Updated•9 years ago
|
Comment 9•9 years ago
|
||
Comment on attachment 8628328 [details] [diff] [review]
1179300-Disable-dynamic-UA-updates-and-add-local.patch
Approving for uplift to Aurora, this has been on m-c for a week with no issues and is low-risk.
Attachment #8628328 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•9 years ago
|
||
Assignee | ||
Comment 11•9 years ago
|
||
Thanks for landing this Ryan.
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•