Closed
Bug 1180528
Opened 9 years ago
Closed 9 years ago
RTL tables wrong order of cells/columns for vertical writing-mode
Categories
(Core :: Layout: Tables, defect)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: fantasai.bugs, Assigned: jfkthame)
References
(Blocks 1 open bug, )
Details
(Keywords: testcase)
Attachments
(2 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
Tables with vertical writing modes don't reverse the order of their columns when assigned 'direction: rtl'.
Comment 1•9 years ago
|
||
Updated•9 years ago
|
Updated•9 years ago
|
Version: 42 Branch → Trunk
Comment 2•9 years ago
|
||
We already had submitted tests on RTL tables, colspanned cells and vertical writing-modes:
[nightly-unstable] colspanned cells, direction: rtl and vertical-rl
http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/table-column-order-004.htm
[nightly-unstable] colspanned cells, direction: rtl and vertical-lr
http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/table-column-order-005.htm
Gérard
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Comment 6•9 years ago
|
||
I'm currently expecting this to get fixed (or at least mostly fixed) in bug 1131451.
Depends on: 1131451
Assignee | ||
Comment 7•9 years ago
|
||
This is fantasai's attachment 8629706 [details], split into two testcases and a reference file for reftest purposes. Test 1b (with RTL in vertical mode) fails with current trunk code, but will pass once the patches from bug 1131451 are landed.
Attachment #8634151 -
Flags: review?(dholbert)
Assignee | ||
Comment 8•9 years ago
|
||
Comment 9•9 years ago
|
||
Comment on attachment 8634151 [details] [diff] [review]
Reftest for table row progression in vertical-rl writing mode with ltr and rtl directionality
Looks good; just nits on the metadata at the top of each file:
>+++ b/layout/reftests/writing-mode/tables/vertical-rl-row-progression-1-ref.html
>@@ -0,0 +1,52 @@
>+<!DOCTYPE html>
>+<title>CSS Test: vertical-rl Table Row/Rowgroup/Cell Ordering</title>
>+<link rel="author" title="Elika J. Etemad" href="http://fantasai.inkedblade.net/contact">
>+<link rel="match" href="table-progression-001-ref.html">
>+<meta name="assert" content="This test checks that vertical-rl tables order rows/rowgroups right to left and cells top-to-bottom (LTR) or bottom-to-top (RTL) per 'direction'.">
(1) Since this is a reference case, its title should say "CSS Reference" instead of "CSS Test: ...
(2) The <link rel="match" ...> tag is bogus. Just remove it from each file here.
(table-progression-001-ref.html isn't a file that exists here; and this ^^ particular usage is in a reference case, which doesn't make sense; and this directory isn't a w3c-submitted test directory, so there's no point in having a <link rel="match" tag here anyway).
(3) <meta name="assert"> should be dropped from just this file. (It talks about this file as a testcase, but this file is a reference case.)
>+++ b/layout/reftests/writing-mode/tables/vertical-rl-row-progression-1a.html
>+<meta name="assert" content="This test checks that vertical-rl tables order rows/rowgroups right to left and cells top-to-bottom (LTR) or bottom-to-top (RTL) per 'direction'.">
[...]
>+<table class="test">
This <meta name="assert"> tag is slightly-wrong here. This file ("b") *only* checks LTR. Please remove mention of RTL.
>+++ b/layout/reftests/writing-mode/tables/vertical-rl-row-progression-1b.html
>+<meta name="assert" content="This test checks that vertical-rl tables order rows/rowgroups right to left and cells top-to-bottom (LTR) or bottom-to-top (RTL) per 'direction'.">
[...]
>+<table dir=rtl class="test">
This <meta name="assert"> tag is slightly-wrong here. This file ("b") *only* checks RTL. Please remove mention of LTR.
r=me with the above addressed.
Attachment #8634151 -
Flags: review?(dholbert) → review+
Comment 10•9 years ago
|
||
Sorry, in my first |This file ("b")|, I meant |This file ("a")|, of course. :)
Assignee | ||
Comment 11•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/2de49bfad9921e71b092846065c562069ecd2a75
changeset: 2de49bfad9921e71b092846065c562069ecd2a75
user: Jonathan Kew <jkew@mozilla.com>
date: Sat Jul 18 11:03:28 2015 +0100
description:
Bug 1180528 - Reftest for table row progression in vertical-rl writing mode with ltr and rtl directionality. r=dholbert
Comment 12•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•