Closed
Bug 1180618
Opened 9 years ago
Closed 9 years ago
Ringer is not managed by Audio Channel Service
Categories
(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)
Tracking
(blocking-b2g:2.5?, b2g-master verified)
People
(Reporter: evanxd, Assigned: evanxd)
References
Details
(Whiteboard: permafail)
Attachments
(3 files)
STR:
1. Play music in Music app.
2. Call the phone device.
3. Call screen is showed.
Excepted result
Music is stopped, and ringer is playing.
Actual result
Music and ringer are playing at same time.
Assignee | ||
Comment 1•9 years ago
|
||
Don't why cannot make a phone call currently in the [1] build.
But this bug is probably related with bug 1183301, just like bug 1181982.
[1]:
Build ID 20150714160203
Gaia Revision f38de9dfec23929ab4cd22ff733c67911676484d
Gaia Date 2015-07-15 08:55:09
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/d5025c151d17
Gecko Version 42.0a1
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20150622.193834
Firmware Date Mon Jun 22 19:38:45 EDT 2015
Bootloader L1TC00011880
Assignee | ||
Updated•9 years ago
|
Summary: Ringer and Music are playing at same time. → Ringer is not managed by Audio Channel Service
Assignee | ||
Comment 2•9 years ago
|
||
Looks like the root cause is that System app doesn't receive "mozSystemWindowChromeEvent" event form gecko.
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Assignee | ||
Comment 5•9 years ago
|
||
Update patch[1] to fix bug.
[1]: https://github.com/evanxd/gaia/commit/a238bc40251336ede12a481fd7a73f48cbb2b62b
Assignee | ||
Comment 6•9 years ago
|
||
We also need to change gecko code[1]
```
this.sendChromeEvent({
type: 'system-audiochannel-state-changed',
name: channel.name,
isActive: evt.target.result
});
```
to
```
SystemAppProxy._sendCustomEvent('mozSystemWindowChromeEvent', {
type: 'system-audiochannel-state-changed',
name: channel.name,
isActive: evt.target.result
});
```
for having consistent mozChromeEvent name called mozSystemWindowChromeEvent.
[1]: https://dxr.mozilla.org/mozilla-central/source/b2g/chrome/content/shell.js#588-592
Assignee | ||
Comment 7•9 years ago
|
||
Update patch[1]: Listen mozSystemWindowChromeEvent event to handle system audio channels.
[1]: https://github.com/evanxd/gaia/commit/4204da4b1cafecaa1ded5343bca9bb6aedc307d0
Assignee | ||
Comment 8•9 years ago
|
||
We already have a patch[1] for this bug. But the bug is just blocked by Bug 1167465.
[1]: https://github.com/evanxd/gaia/commit/7252c43a38c757f88d6e4cd45cd181330ee0b8d6
Assignee | ||
Comment 14•9 years ago
|
||
The patch[1] for exposing Audio Channels in System App's window is not working now. That still blocks this bug. Alastor is fixing that.
[1]: http://bugzil.la/1167465
Comment 15•9 years ago
|
||
This bug still exists in OGA Music and NGA Music on Flame 2.5 latest build.
STR:
1. Play a music by OGA Music or NGA Music.
2. Incoming a call
Actual result:
Music and ringer are playing at same time.
Device:Flame 2.5(affected):
Build ID 20150927150205
Gaia Revision 285486b417f1cb8316b19c0698a6655fc053fbd6
Gaia Date 2015-09-25 14:11:30
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/6256ec9113c115141aab089c45ee69438884b680
Gecko Version 44.0a1
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20150927.184956
Firmware Date Sun Sep 27 18:50:08 EDT 2015
Firmware Version v18D v4
Bootloader L1TC000118D0
Assignee | ||
Comment 16•9 years ago
|
||
WIP patch: https://github.com/evanxd/gaia/commit/5559d0c1cc18f573bdfc1840120e9e4ba4001d47
The patch already fix the issue, then we need to remove useless coded.
Assignee | ||
Comment 17•9 years ago
|
||
Remove useless code: https://github.com/evanxd/gaia/commit/7c8c4ff14f66364dcf5d0d6aed82cc04f8783dc2
Updated•9 years ago
|
Whiteboard: [2.5-aries-test-run-1][2.5-aries-test-run-2] → [2.5-aries-test-run-1][2.5-aries-test-run-2], permafail
Updated•9 years ago
|
Whiteboard: [2.5-aries-test-run-1][2.5-aries-test-run-2], permafail → permafail
Comment 18•9 years ago
|
||
[Blocking Requested - why for this release]:
No longer blocks: 1205048
blocking-b2g: --- → 2.5?
Assignee | ||
Comment 19•9 years ago
|
||
Updated patch to update unit tests: https://github.com/evanxd/gaia/commit/eef93e9b180cfaa800575f830880f009a7eb81c2
Assignee | ||
Comment 20•9 years ago
|
||
Comment on attachment 8639748 [details]
[gaia] evanxd:bug-1180618 > mozilla-b2g:master
Hi Alastor,
Could you review the patch?
Thanks.
Attachment #8639748 -
Flags: review?(alwu)
Assignee | ||
Comment 21•9 years ago
|
||
Don't why all Gij tasks[1] are failed. Fixing it!
[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&fromchange=96a1f9bcf70ba4855c62d4b030a7b18f664274d3
Comment 22•9 years ago
|
||
Hi, Evan,
I think you post the wrong link, this link is about the try result of the bug1199420.
Assignee | ||
Comment 23•9 years ago
|
||
Thanks, Alastor.
Fix this: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=eef93e9b180cfaa800575f830880f009a7eb81c2
Assignee | ||
Comment 24•9 years ago
|
||
Updated patch[1] to fix failed Gij tasks and remove useless code.
[1]: https://github.com/evanxd/gaia/commit/84e11a6036ea38495083bbb831d9b3c3a6348e75
Assignee | ||
Comment 25•9 years ago
|
||
The treeherder[1] for Comment 24.
[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=84e11a6036ea38495083bbb831d9b3c3a6348e75
Assignee | ||
Comment 26•9 years ago
|
||
Hi Alastor,
Looks like I already fixed the failed Gij tasks.
Please help to continue to review the patch.
Thanks.
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(alwu)
Updated•9 years ago
|
Flags: needinfo?(alwu)
Attachment #8639748 -
Flags: review?(alwu) → review+
Comment 27•9 years ago
|
||
Evan, it looks like you rewrite the logic when the sound is played by System app? The patch here doesn't match the problem you described in comment 2. Could you write down the actual problem and why do we need to fix in this way? Thanks.
Updated•9 years ago
|
Flags: needinfo?(evan)
Assignee | ||
Comment 28•9 years ago
|
||
Gecko exported allowed audio channels in System App's Window in Bug 1167465.
It means that System app can access its allowed audio channels directly. For example, we can do `navigator.mozAudioChannelManager.allowedAudioChannels` to get all audio channels in System app. (It's only for System app)
So no need to depend on `mozSystemWindowChromeEvent` to get or control System app's allowed audio channels.
Flags: needinfo?(evan)
Assignee | ||
Comment 29•9 years ago
|
||
Alastor, thanks for the review.
Assignee | ||
Comment 30•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 31•9 years ago
|
||
This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aries KK 2.5 by the STR in comment 0 .
Actual results: Music is stopped, and ringer is playing.
See attachment: verified_logcat_1811.txt, verified_Aries_KK v2.5.3gp.
Reproduce rate: 0/10.
Device: Flame KK 2.5 (Pass)
Build ID 20151020150236
Gaia Revision 11eb5d4cb2675d359d277ae17772bc75f7ccedbc
Gaia Date 2015-10-20 16:22:28
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/f397034950304b845175f8dab8fccbdd0e8bf995
Gecko Version 44.0a1
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20151020.182846
Firmware Date Tue Oct 20 18:28:58 EDT 2015
Firmware Version v18D v4
Bootloader L1TC000118D0
Device: Aries KK 2.5 (Pass)
Build ID 20151020225607
Gaia Revision 11eb5d4cb2675d359d277ae17772bc75f7ccedbc
Gaia Date 2015-10-20 16:22:28
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/f397034950304b845175f8dab8fccbdd0e8bf995
Gecko Version 44.0a1
Device Name aries
Firmware(Release) 4.4.2
Firmware(Incremental) eng.worker.20151020.221418
Firmware Date Tue Oct 20 22:14:26 UTC 2015
Bootloader s1
Status: RESOLVED → VERIFIED
Comment 32•9 years ago
|
||
Comment 33•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•