Closed
Bug 1181982
Opened 9 years ago
Closed 9 years ago
[B2G] Manage the sound of the attention window
Categories
(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)
Tracking
(blocking-b2g:2.5+, b2g-master fixed)
Tracking | Status | |
---|---|---|
b2g-master | --- | fixed |
People
(Reporter: evanxd, Assigned: evanxd)
References
Details
(Keywords: regression, smoketest, Whiteboard: [dogfood-blocker])
Attachments
(1 file)
STR: 1. Set alarm in Clock app. 2. Play music in Music app. 3. Alarm is ringing. Excepted result: Alarm is playing, but music is not. Actual result: Alarm and music are playing at same time.
Assignee | ||
Comment 1•9 years ago
|
||
Looks like it is a gecko bug related with [1]. After applying the [2] patch and do the STR, you could see the below log. ``` I/GeckoConsole( 4261): Content JS LOG: bug 1181982: Music registers audio channels I/GeckoConsole( 4261): Content JS LOG: bug 1181982: audioChannels: [object BrowserElementAudioChannel],[object BrowserElementAudioChannel] I/GeckoConsole( 4261): Content JS LOG: bug 1181982: Clock registers audio channels I/GeckoConsole( 4261): Content JS LOG: bug 1181982: audioChannels: [object BrowserElementAudioChannel],[object BrowserElementAudioChannel] I/GeckoConsole( 4261): Content JS LOG: bug 1181982: clock.gaiamobile.org registers audio channels ``` The alarm attention window cannot get the `allowedAudioChannels`. Then the Audio Channel Service[3] cannot manage it. That's the root cause of this bug. [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1183301#c9 [2]: https://github.com/evanxd/gaia/commit/f38de9dfec23929ab4cd22ff733c67911676484d [3]: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/audio_channel_service.js
Assignee | ||
Updated•9 years ago
|
Assignee: evanxd → nobody
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → evanxd
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Treeherder: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=61ed5e9b0ec095684e23501afad9f6b1b33bc20f
Assignee | ||
Comment 4•9 years ago
|
||
Discussed with Kan-Ru and Alastor offline, we need to wait for mozbrowserloadend to get allowedAudioChannels from browser element.
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8634629 [details]
[gaia] evanxd:bug-1181982 > mozilla-b2g:master
Hi Dominic,
Could you help to review the patch?
Thanks.
Attachment #8634629 -
Flags: review?(dominic.kuo)
Comment 9•9 years ago
|
||
Comment on attachment 8634629 [details]
[gaia] evanxd:bug-1181982 > mozilla-b2g:master
Looks like we have to wait for mozbrowserloadend then can get correct allowedAudioChannels for app windows, and the patch does the right thing so looks good to me.
Attachment #8634629 -
Flags: review?(dominic.kuo) → review+
Assignee | ||
Comment 10•9 years ago
|
||
Dominic, thanks for the review. But the patch causes some Gij failures, go fixing the tests.
Assignee | ||
Comment 11•9 years ago
|
||
First step, restart all treeherder tasks. The treeherder: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=ae307813f5a5fa988cb1044a285d82f32f4355c6
Assignee | ||
Comment 12•9 years ago
|
||
Still had Gij failures[1]. Fixing them. [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=5132a9c656c9bb3e23ac09e3f23cfd28c1cb8f83
Assignee | ||
Comment 13•9 years ago
|
||
New treeherder: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=03a11aa4495a2063d7ae3c447c94506751890ea9
Comment 15•9 years ago
|
||
This bug can solve the problem that we can't manage the sound of the attention window. For example, the alarm starts.
Summary: Alarm and Music are playing at same time. → [B2G] Manage the sound of the attention window
Assignee | ||
Comment 16•9 years ago
|
||
Patch[1] to fix unit tests. Check the treeherder[2]. [1]: https://github.com/evanxd/gaia/commit/97e6d42ac48f3cc6d42f6391bff4f14a9ef0b3da [2]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=97e6d42ac48f3cc6d42f6391bff4f14a9ef0b3da
Assignee | ||
Comment 17•9 years ago
|
||
Update patch[1], and the treeherder[2]. [1]: https://github.com/evanxd/gaia/commit/e1d6902585bb6e20d9d392af832e543b1f5bd844 [2]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=e1d6902585bb6e20d9d392af832e543b1f5bd844
Assignee | ||
Comment 18•9 years ago
|
||
Two more tries[1][2]. [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=9e649d536d1b3f1d8d569053de547c05f3c3f1c9 [2]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=1f00659fe1554e2bbb7e0f92d6b9e9e59f07aa51
Carrying over the flags from dupe (bug 1186050)
Assignee | ||
Comment 20•9 years ago
|
||
new treeherder: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=7b224c6c1af138b46e8f9a68482db214826248b7
Assignee | ||
Comment 21•9 years ago
|
||
new try[1][2] [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=cf8d1195301f11ad4d5a01ce16957cf4bace173e [2]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=dfb746dbbfaff5202d33d6f0d4db66e646cdddee
Assignee | ||
Comment 22•9 years ago
|
||
new try: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=2ef4fae9ea093d13664b6c9fc3a21d223acb7c0a
Assignee | ||
Comment 23•9 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/2ae9a4c6fa09567dd079a0907e35673f1813e402
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [dogfood-blocker]
Comment 24•9 years ago
|
||
This issue is verified fixed on the latest Spark 2.5 build. Alarms properly pause playing music before audibly sounding themselves, then un-pause the music when the alarm is dismissed. Environmental Variables: Device: Aries 2.5 Build ID: 20150724113133 Gaia: db299103dd17a873cba4ff88e62ec173bf80fe62 Gecko: 9bca608ab65a Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd Version: 42.0a1 (2.5) Firmware Version: D5803_23.1.A.1.28_NCB.ftf User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(onelson)
Updated•9 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(onelson)
Updated•9 years ago
|
Updated•9 years ago
|
Target Milestone: --- → FxOS-S3 (24Jul)
You need to log in
before you can comment on or make changes to this bug.
Description
•