It's not easy to handle artifact uploads thoroughly in the bash script as is (while still supporting multiple job types). The process should be more forgiving: printing messages when a file is skipped, but not failing the whole task.

A try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=732e0d5f10cc&exclusion_profile=false

Another try... https://treeherder.mozilla.org/#/jobs?repo=try&revision=032135c85680&exclusion_profile=false

Comment on attachment 8630062 [details] [diff] [review] missing-artifacts.diff Review of attachment 8630062 [details] [diff] [review]: ----------------------------------------------------------------- I don't object to the fix, but it does seem like something's not right here..

I'm told :mshal has been struggling with this as well -- the build system should, ideally, indicate exactly which files need to be uploaded. Either by putting them in a specific directory (and it seems 'dist' is not that directory, since it contains scads of files) or by providing some kind of manifest file.

We do this to some degree by exporting the value of UPLOAD_FILES into mach_build_properties.json at the end of a successful build with MOZ_AUTOMATION set. The downside is that UPLOAD_FILES doesn't include things like l10n packages, since those are built with targetted make commands and separate 'make upload AB_CD=foo' steps.

Should we aim to extend that mechanism to support l10n, or do something else?

I'm certainly open to alternatives - the upload list in mach_build_properties was primarily added to support mozharness doing TC uploads. It could just as easily do that by looking for files in a specific upload directory, but I don't know if using an upload directory makes l10n easier or not.

(In reply to Michael Shal [:mshal] from comment #7) > I'm certainly open to alternatives - the upload list in > mach_build_properties was primarily added to support mozharness doing TC > uploads. It could just as easily do that by looking for files in a specific > upload directory, but I don't know if using an upload directory makes l10n > easier or not. Using the upload list seems like a better way to address this bug, I'll try to get out a patch for that. In the meantime, we need a unified way to handle finding artifacts after a job: configuring by hand like right now is too prone to breakage. If we can make it work with l10n, just moving things to a specific directory would be the cleanest way to handle this I think: after a job, we can just do mv <somedir> ~/artifacts and be done with it.

s/in the meantime/after that/

Comment on attachment 8630062 [details] [diff] [review] missing-artifacts.diff Going with a more sophisticated approach.