Closed
Bug 1181953
Opened 9 years ago
Closed 9 years ago
[UX] Define interface needed to support containers
Categories
(Firefox :: Security, defect)
Firefox
Security
Tracking
()
RESOLVED
FIXED
People
(Reporter: englehardt, Assigned: englehardt)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [userContextId])
Attachments
(5 files, 9 obsolete files)
The containers project needs UX elements that signify which container the user is currently in. As a first pass, we expect to add highlighting on tabs and address bar indicator icons/titles.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → senglehardt
Comment 1•9 years ago
|
||
When you file bugs, can you either try to link them to other bugs that explain more of the project they're for using the blocks/"depends on" field, or ensure that the description/summary are understandable for people active in the area where you're filing the bug? (Right now I wonder what containers are, and what kind of highlighting this is, and what project this is for, and if it's related to UITour or not, and... well, I have a lot of questions, but "containers" is a very general term so it's not helpful if I have no context. :-) )
Flags: needinfo?(senglehardt)
Assignee | ||
Comment 2•9 years ago
|
||
Gjis: I may have filed this in the
Component: Theme → Security
Flags: needinfo?(senglehardt)
Assignee | ||
Comment 3•9 years ago
|
||
Gjis: I likely filed this bug in the wrong place. We are using this as a place holder for some UX mockups for a new content security project. I've changed it to Security.
Comment 4•9 years ago
|
||
Comment 5•9 years ago
|
||
Comment 6•9 years ago
|
||
Comment 7•9 years ago
|
||
Comment 8•9 years ago
|
||
Colour values (used to set container name on location bar):
* Personal: #00a7e0
* Work: #f89c24
* Banking: #7dc14c
* Shopping: #ee5195
Comment 9•9 years ago
|
||
Work and shopping icons may get confusing if people take the orange briefcase to be a shopping bag. Making the briefcase grey or black would solve this problem, except that black isn't all that pretty and grey won't work given the tab itself is grey. Maybe since the icon always shows up next to the name of the container, this is okay.
Updated•9 years ago
|
Comment 10•9 years ago
|
||
Looks like Bram and Francois created a wiki for this project! https://wiki.mozilla.org/Security/Contextual_Identity_Project/Containers
Steve/Bram, once we have some more of this worked out, it would be helpful to update the wiki.
Comment 11•9 years ago
|
||
(In reply to Tanvi Vyas [:tanvi] from comment #10)
> Steve/Bram, once we have some more of this worked out, it would be helpful
> to update the wiki.
I’ve started updating the wiki with the latest mockup and information. Feel free to continue building on top of it.
Comment 12•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Blocks: ContextualIdentity
Assignee | ||
Comment 13•9 years ago
|
||
Bram: I just want to confirm that it is fine to land patches with these assets in Nightly. We'll hopefully have a few shortly (Bug 1191494). Thanks!
Flags: needinfo?(bram)
Comment 14•9 years ago
|
||
Yep. These icons should be fine for a first pass (ie. test to a limited audience, like Nightly and Dev Edition).
Flags: needinfo?(bram)
Comment 15•9 years ago
|
||
Attachment #8631974 -
Attachment is obsolete: true
Comment 16•9 years ago
|
||
Updated•9 years ago
|
Attachment #8631975 -
Attachment is obsolete: true
Comment 17•9 years ago
|
||
Attachment #8631976 -
Attachment is obsolete: true
Comment 18•9 years ago
|
||
Attachment #8631977 -
Attachment is obsolete: true
Comment 19•9 years ago
|
||
Updated all container icons to follow formatting outlined by Paolo in bug 1191455 comment 4.
Steven, do they look good?
Flags: needinfo?(senglehardt)
Assignee | ||
Comment 20•9 years ago
|
||
(In reply to Bram Pitoyo [:bram] from comment #19)
> Updated all container icons to follow formatting outlined by Paolo in bug
> 1191455 comment 4.
>
> Steven, do they look good?
Awesome, thanks Bram!
The `xmlns:xlink="http://www.w3.org/1999/xlink` namespace declaration is unnecessary since we aren't using xlinks. It looks like you stripped out all other unnecessary information.
Also, I believe the viewBox should be `viewBox="0 0 32 32"` rather than `viewBox="0 0 16 16"` (If I understand the viewBox property correctly -- https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/viewBox).
Flags: needinfo?(senglehardt)
Comment 21•9 years ago
|
||
Attachment #8655143 -
Attachment is obsolete: true
Comment 22•9 years ago
|
||
Attachment #8655144 -
Attachment is obsolete: true
Comment 23•9 years ago
|
||
Attachment #8655145 -
Attachment is obsolete: true
Comment 24•9 years ago
|
||
Attachment #8655146 -
Attachment is obsolete: true
Comment 25•9 years ago
|
||
* Strip out `xmlns:xlink`
* Changed `viewBox` to `0 0 32 32`
* Path declaration values changed to reflect the new dimension
I think this should fulfil our requirements.
Assignee | ||
Comment 26•9 years ago
|
||
(In reply to Bram Pitoyo [:bram] from comment #25)
> * Strip out `xmlns:xlink`
> * Changed `viewBox` to `0 0 32 32`
> * Path declaration values changed to reflect the new dimension
>
> I think this should fulfil our requirements.
The updates look good for Personal, Banking, and Shopping. However the path is incorrect for work (briefcase handle not showing).
Flags: needinfo?(bram)
Updated•9 years ago
|
Attachment #8655159 -
Attachment is obsolete: true
Updated•9 years ago
|
Whiteboard: [userContextId]
Comment 28•9 years ago
|
||
This bug is complete. Only remaining item is the hamburger menu option which I will file a new bug for:
https://bug1181953.bmoattachments.org/attachment.cgi?id=8640888
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 29•9 years ago
|
||
(In reply to Tanvi Vyas [:tanvi] from comment #28)
> This bug is complete. Only remaining item is the hamburger menu option
> which I will file a new bug for:
> https://bug1181953.bmoattachments.org/attachment.cgi?id=8640888
Created https://bugzilla.mozilla.org/show_bug.cgi?id=1269029
You need to log in
before you can comment on or make changes to this bug.
Description
•