Open Bug 1182876 Opened 9 years ago Updated 2 years ago

Use the built-in entries for test-track-simple and test-trackwhite-simple in mochitests

Categories

(Toolkit :: Safe Browsing, defect, P3)

defect

Tracking

()

REOPENED

People

(Reporter: francois, Unassigned)

References

Details

Attachments

(2 files, 1 obsolete file)

We currently have test-phish-simple and the likes for Safe Browsing unit tests. We need the same thing for tracking protection.
I have suggested that some test files be served from the same domain as the shavar server: https://github.com/mozilla-services/shavar/issues/43
I've just registered two domains that I will be adding to the test list: - itisatracker.org - itisatracker.com
Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp
Attachment #8635496 - Flags: review?(dcamp)
Comment on attachment 8635496 [details] MozReview Request: Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp
Attachment #8635496 - Flags: review?(dcamp)
Summary: Create test-track-simple to provide a stable tracking URL for testing purposes → Use the built-in entries for test-track-simple and test-trackwhite-simple in mochitests
Comment on attachment 8635496 [details] MozReview Request: Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp The URLs themselves were added in bug 1185549. I will simplify the mochitests so that they use the built-in URLs and don't require toolkit/components/url-classifier/tests/UrlClassifierTestUtils.jsm anymore.
Attachment #8635496 - Attachment is obsolete: true
The test-trackwhite-simple table will be added in bug 1141352.
No longer blocks: 1149825
Depends on: 1141352
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-active]
Blocks: 1245363
Assignee: francois → nobody
Status: ASSIGNED → NEW
Component: DOM: Security → Safe Browsing
Product: Core → Toolkit
Whiteboard: [domsecurity-active]
Priority: -- → P2
Priority: P2 → P3
Attached patch WIP patch (deleted) — Splinter Review
Attached patch WIP patch (UI tests) (deleted) — Splinter Review
Blocks: 1214437
:francois, can you work on getting these fixes in place so we can see bug 1214437 fixed or reduced?
Flags: needinfo?(francois)
(In reply to Joel Maher ( :jmaher) from comment #10) > :francois, can you work on getting these fixes in place so we can see bug > 1214437 fixed or reduced? How important would you say it is? I probably won't have time to look at it for several weeks but I can try to find someone else if you think it should be prioritized higher than a P3.
Flags: needinfo?(francois) → needinfo?(jmaher)
This showed up as a potential fix for a high frequency intermittent last week. Overall, the frequency of that specific failure went down quite a bit- So I would like to see this in, but I don't think we should prioritize it above other work. If we can have this landed next month, that would be ideal. If bug 1214437 picks up in frequency again, I will check back in here.
Flags: needinfo?(jmaher)
the failure rate of these tests have been greatly reduced, not sure if it is coincidence or a fix!
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INACTIVE
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: