Closed
Bug 1183747
Opened 9 years ago
Closed 9 years ago
load_job_artifacts() should not support both list and dict artifact formats
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: wlach)
Details
Attachments
(1 file)
...since it's not very clear, and we're possibly only compressing the blob in some of the codepaths:
https://github.com/mozilla/treeherder/blob/c16772d5d6e2c558baf5b440ffb78658dab48c00/treeherder/model/derived/artifacts.py#L200-L228
|
Assignee | |
Comment 1•9 years ago
|
||
The worst part of this is that some code paths (e.g. performance artifact ingestion) are only operative for the dict format. We should just support dicts and be done with it IMO.
I have a patch in progress for this, so I'm going to steal it.
Assignee: emorley → wlachance
|
|
Assignee | |
Comment 2•9 years ago
|
||
This passes the unit tests and some simple ingestion tests I ran on a local vagrant instance.
Attachment #8644665 -
Flags: review?(emorley)
|
Reporter | |
Updated•9 years ago
|
Attachment #8644665 -
Flags: review?(emorley) → review+
|
||
Comment 3•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/59f2db20d3823ef2a69d6833331f350b9747ceaf
Bug 1183747 - Simplify ingestion of artifacts submitted with a job
There's no need to have a gigantic codepath converting them into a
list-- all we need is some simple logic to add a guid to them.
|
|
Assignee | |
Comment 4•9 years ago
|
||
This seems to be working fine after 3+ days of testing on stage, merged.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•