Closed Bug 1183923 Opened 9 years ago Closed 9 years ago

Add the ability to manually backfill jobs on demand by a privileged user (Treeherder part)

Categories

(Tree Management :: Treeherder, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vaibhav1994, Assigned: vaibhav1994)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 2 obsolete files)

This bug will involve creating a UI for backfilling in Treeherder and a pulse backend, and it will be for privileged users (sheriffs). On clicking the button, it will trigger jobs on revisions till the last known job(success or failed). It will be helpful for general manual back-filling, as well as back-filling talos jobs.
Assignee: nobody → vaibhavmagarwal
Attached image Backfill Icon (obsolete) (deleted) —
Hi, I would like your feedback for the UI of backfill button. It is in the pluginpanel, with the retry symbol and "BF" for backfill written beside it. It will be a sheriff only option for time being. Does it make sense?
Attachment #8633834 - Flags: feedback?(wkocher)
Attachment #8633834 - Flags: feedback?(ryanvm)
Attachment #8633834 - Flags: feedback?(cmanchester)
Comment on attachment 8633834 [details] Backfill Icon Looks good. Is there some way to add a tooltip or more info in a help section?
Attachment #8633834 - Flags: feedback?(cmanchester) → feedback+
Comment on attachment 8633834 [details] Backfill Icon Eh, I don't think it's a frequent enough thing to warrant space in that row of buttons. I'd say it could just be a text link in the "Job Details" pane.
Attachment #8633834 - Flags: feedback?(wkocher) → feedback-
Attached image Backfill hover (obsolete) (deleted) —
Chris, yes it shows "Backfill this till last seen job" when we hover over it, as you can see in this pic.
Attached image Backfill Type 2 (deleted) —
Is this way in the UI better?
Attachment #8633843 - Flags: feedback?(wkocher)
Attachment #8633843 - Flags: feedback?(cmanchester)
There is a "Backfill this job till last seen" link in the "Job Details" pane of Backfill Type 2 Button. Let me know if that is better to have.
Comment on attachment 8633843 [details] Backfill Type 2 I'll defer to the sheriffs on this.
Attachment #8633843 - Flags: feedback?(cmanchester)
Attached image Backfill option #3 (deleted) —
How about this?
Attachment #8633852 - Flags: feedback?(vaibhavmagarwal)
Ok. Cool!
Comment on attachment 8633852 [details] Backfill option #3 Thanks Wes for the prompt feedback!
Attachment #8633852 - Flags: feedback?(vaibhavmagarwal) → feedback+
Attached file github-pr (deleted) —
:mdoglio, could you please review this patch? I am placing the link in the job-details-pane view, as advised by :KWeirso
Attachment #8633834 - Attachment is obsolete: true
Attachment #8633838 - Attachment is obsolete: true
Attachment #8633834 - Flags: feedback?(ryanvm)
Attachment #8633888 - Flags: review?(mdoglio)
Comment on attachment 8633888 [details] github-pr I added a few comments to the pull request, r? me when it's ready for a second review
Attachment #8633888 - Flags: review?(mdoglio) → review-
Comment on attachment 8633888 [details] github-pr Fixed the comments, and rebased on latest master. :mdoglio, could you please review this patch? Thanks!
Attachment #8633888 - Flags: review- → review?(mdoglio)
Attachment #8633888 - Flags: review?(mdoglio) → review+
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/be0c80847e750efd74390f1d53bc983e4a003614 Bug 1183923 - Front-end UI and publish to pulse for 'backfill' action https://github.com/mozilla/treeherder/commit/996518ed347a0886050aeee731e07e476dd9c180 Merge pull request #760 from vaibhavmagarwal/backfill Bug 1183923 - Front-end UI and publish to pulse for 'backfill' action
Attached file pr #775 (deleted) —
:mdoglio, this patch fixes the "backfill" action locally for me. Could you review this? Thanks!
Attachment #8634845 - Flags: review?(mdoglio)
Attachment #8634845 - Flags: review?(mdoglio) → review+
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/b884f7121aee9a707aea439077d4e1d8084a5f45 Bug 1183923 - Fix for publish "backfill" action on pulse. https://github.com/mozilla/treeherder/commit/719040240849a6d5f1a3d406cf0d27ce90f43625 Merge pull request #775 from vaibhavmagarwal/backfill-fix Bug 1183923 - Fix for publish "backfill" action on pulse.
Status: NEW → ASSIGNED
:vaibhav1994, if this completes the bugfix, can you mark the bug fixed? Thanks :)
(Moving to a Treeherder component; it breaks the component watching workflow if Treeherder changes are made in non-Treeherder components :-))
Component: General → Treeherder
Product: Testing → Tree Management
Version: unspecified → ---
There is still some work remaining to pass the pulse messages to listeners and act on it. So, when that will be in place, I will close this bug.
Let's use a separate bug, since that work is outside of treeherder, so a different bugzilla component. (Bugs are cheap :-) )
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Summary: Add the ability to manually backfill jobs on demand by a privileged user. → Add the ability to manually backfill jobs on demand by a privileged user (Treeherder part)
The dropdown that now lives on the button makes it require two clicks to retrigger a job, which is super annoying when doing a bunch of retriggers. :-( Can't we just add fifth button or something?
(In reply to Bobby Holley (:bholley) from comment #24) > The dropdown that now lives on the button makes it require two clicks to > retrigger a job, which is super annoying when doing a bunch of retriggers. > :-( Can't we just add fifth button or something? Bug 1207460 or bug 1207592. Alternatively, the 'R' keyboard shortcuts can retrigger a selected job many times really quickly.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: