Currently we have some AudioChannelAgents initialized with a null window. These should be muted by default or crash.

This patch will help to detect where we have AudioChannelAgents with a null window.

Comment on attachment 8634022 [details] [diff] [review] detect.patch Review of attachment 8634022 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, Thanks!

Alwu, any news to remove the AudioChannelAgent with null window in telephony and AudioManager?

Before landing this issue, we should remove the null window telephony/ringtone agent in AudioManage.cpp. (1) Remove telephony agent - bug1129882 We only need to wait for the this bug, and it should be landed after your review :) But if we want to manage the telephony correctly, it will be done after bug1185442. (2) Remove ringtone agent - bug1185442 Now I am waiting for the feedback from Gabriele. We plan to playback a silent ringtone when there is incoming call during the vibration mode. If we can do it in Gaia, I can remove the codes in Gecko.

Sorry, correct the comment4. Removing ringtone agent would be implemented in this bug, bug1184482.

alwu, can we land this patch?

Yes :)

Hi, Baku, Maybe we still need to postpone landing this issue, see bug1193840 comment7.

ok. Can you set a dependence so that when that is landed we can land this patch too? Thanks.

Shall we try to land the patch?

Ok, all null agents have been removed. Although the bug1129882 is opened again, I think it doesn't affect this bug. Sorry for the delay.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0708602ea554dddb31bdbf172596fc2e29ca832e Bug 1184058 - AudioChannelAgent should be muted when used without a proper window object, r=alwu

This patch has d2 bustages like this https://treeherder.mozilla.org/logviewer.html#?job_id=13360819&repo=mozilla-inbound. Going to back it out.

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/f4f537fe2647

https://hg.mozilla.org/integration/mozilla-inbound/rev/ddc08e87843f8578adb0ba42887f66044358d563 Bug 1184058 - AudioChannelAgent should be muted when used without a proper window object, r=alwu

Backed out for AudioChannelAgent crashes/asserts. https://treeherder.mozilla.org/logviewer.html#?job_id=13554814&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=13556810&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/499f911151a0