Gabriele Svelto [:gsvelto] Reporter
	Description • 9 years ago

+++ This bug was initially created as a clone of Bug #1129882 +++

Now that audio channel management is being moved from gaia to gecko we don't need to react to mozinterruptbegin anymore in the dialer and all the associated code should be removed together with the tests; see bug 1129882 comment 61.

	Alastor Wu [:alwu]
	Comment 2 • 9 years ago

We need this bug, and then we can land the bug1129882 and bug1184058.
See bug1193840 comment7.

	Alastor Wu [:alwu]
	Comment 3 • 9 years ago

Hi, Gabriele,
Could you help with this issue?
Very appreciate :)

	(no longer active)
	Comment 4 • 9 years ago

It would be wonderful to fix this very soon since it would probably fix bug 1195805...  I really appreciate the help!

	(no longer active)
	Comment 5 • 9 years ago

[Blocking Requested - why for this release]: Because this will fix the blocker bug 1195805.

	Mahendra Potharaju [:mahe]
	Comment 6 • 9 years ago

Required to fix other blockers. 2.5+ed

	Kevin Grandon :kgrandon Assignee
	Comment 7 • 9 years ago

Will take a stab at this.

	Kevin Grandon :kgrandon Assignee
	Comment 9 • 9 years ago

Comment on attachment 8649987 [details]
[gaia] KevinGrandon:bug-1185442_dialer_remove_mozinterruptbegin > mozilla-b2g:master

Hi Gabriele - I think this is the right thing to do, could you review this? Thanks!

	Gabriele Svelto [:gsvelto] Reporter
	Comment 10 • 9 years ago

Comment on attachment 8649987 [details]
[gaia] KevinGrandon:bug-1185442_dialer_remove_mozinterruptbegin > mozilla-b2g:master

Looking good, thanks for taking care of this!

	(no longer active)
	Comment 11 • 9 years ago

Thanks Kevin, you rock!  :-)

One question, since I would like to take bug 1195051 on Aurora, does the gaia patch here need to be backported somewhere too?

	Kevin Grandon :kgrandon Assignee
	Comment 12 • 9 years ago

Thank you for the review Gabriele. In master: https://github.com/mozilla-b2g/gaia/commit/c6705f739fb605031eb2a0b943ba55c64bee5a03

(In reply to Ehsan Akhgari (don't ask for review please) from comment #11)
> Thanks Kevin, you rock!  :-)
> 
> One question, since I would like to take bug 1195051 on Aurora, does the
> gaia patch here need to be backported somewhere too?

Yes, we would need to uplift this, I think we just need to ask for approval for gaia v2.2 I think. We should probably ask for approval at the same time and cross-reference the bugs.

	Johan Lorenzo [:jlorenzo] - On PTO, back on September 11th
	Comment 13 • 9 years ago

(In reply to Ehsan Akhgari (don't ask for review please) from comment #11)
> One question, since I would like to take bug 1195051 on Aurora, does the
> gaia patch here need to be backported somewhere too?

To my knowledge, the current aurora is not used by any Firefox OS version. 2.2 relies on Gecko 37 and 2.5 will be based upon Gecko 44.

	(no longer active)
	Comment 14 • 9 years ago

Hmm, according to what Johan said, this shouldn't be taken on 2.2.  Do you agree?

	[:fabrice] Fabrice Desré
	Comment 15 • 9 years ago

yes, Johan is correct.

Do we also have to fix all the other uses of mozinterruptbegin in gaia?

	Kevin Grandon :kgrandon Assignee
	Comment 16 • 9 years ago

> Hmm, according to what Johan said, this shouldn't be taken on 2.2.  Do you agree?

Ok, thanks for the clarification. So it sounds like this doesn't need to be uplifted anywhere?

	(no longer active)
	Comment 17 • 9 years ago

(In reply to [:fabrice] Fabrice Desré from comment #15)
> Do we also have to fix all the other uses of mozinterruptbegin in gaia?

Probably.  It seems like in the code that was removed, gaia was assuming that the AudioContext starts to play back audio as soon as it was created, however that was a bug in Gecko that we fixed, and now AudioContext actually starts to play back audio when you connect something to its destination node that will start audio playback.  So if there are other places in gaia that were relying on this Gecko bug, they need to be fixed as well.

	Kevin Grandon :kgrandon Assignee
	Comment 18 • 9 years ago

You can't back this out as it would result in another smoketest blocker (probably worse than bug 1198824) getting opened.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 19 • 9 years ago

kgrandon, Could you come up with a forward fix to fix the smoke test blocker please?  :D

	Kevin Grandon :kgrandon Assignee
	Comment 20 • 9 years ago

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #19)
> kgrandon, Could you come up with a forward fix to fix the smoke test blocker
> please?  :D

Not sure yet, but let's keep that in the proper bug.