Closed Bug 1185358 Opened 9 years ago Closed 4 years ago

Paste words in location bar: newlines are removed, words are merged

Categories

(Firefox :: Address Bar, enhancement, P3)

Product:
Firefox
Component:
Address Bar
Version:
39 Branch
Type:
enhancement
Points:
3

Tracking

()

Status:
VERIFIED FIXED
Milestone:
87 Branch
Iteration:
88.1 - Feb 22 - Mar 7
Tracking Flags:
Tracking Status
firefox87 --- verified

People

(Reporter: rip0320, Assigned: daisuke)

References

Details

(Keywords: papercut)

Attachments

(2 files)

Bug 1185358: Replace any whitespace chars with space.
(deleted), text/x-phabricator-request
Details
Bug 1185358: Update untrimmedValue even if pasted value is changed.
(deleted), text/x-phabricator-request
Details
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:39.0) Gecko/20100101 Firefox/39.0 Build ID: 20150629114848 Steps to reproduce: Pasted this multi-line string into the awesome location bar: White House Washington DC USA Actual results: My string got transformed and this is what got in the bar: White HouseWashington DCUSA Expected results: White House Washington DC USA
2 legit use cases are conflicting here. First, when user wants to paste an URL, and this URL might have been broken into piece by a mail software or other. The correct behavior is to remove the newline and merge the long URL pieces, as discussed in bug 1014246. This already works. Second, when user wants to search terms (e.g. a geographic address, a sentence, etc.). The correct behavior is to replace each newline by a space. This currently doesn't work. I understand the choice might not always be obvious. Afaict, the same use cases in Chromium always work as expected.
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Component: Untriaged → Location Bar
Ever confirmed: true
Blocks: 1425024
Priority: -- → P3
Whiteboard: [fxsearch]

we should be able to detect if the string looks like a url or not, in most cases.

Severity: normal → S3
Keywords: papercut
Whiteboard: [fxsearch]
Points: --- → 3
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Iteration: --- → 88.1 - Feb 22 - Mar 7

Depends on D105726

Attachment #9204140 - Attachment description: Bug 1185358: Replace any whitespace chars to space. → Bug 1185358: Replace any whitespace chars with space.
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e4a60e1d9ef5 Replace any whitespace chars with space. r=adw https://hg.mozilla.org/integration/autoland/rev/22e706c2ff1d Update untrimmedValue even if pasted value is changed. r=adw

https://hg.mozilla.org/mozilla-central/rev/e4a60e1d9ef5
https://hg.mozilla.org/mozilla-central/rev/22e706c2ff1d

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
QA Whiteboard: [qa-87b-p2]

The issue as described in comment 0, and other similar test cases, is no longer reproducible in latest 87 beta 5 across OS's, so I'm marking this as verified.

However, the two duplicates bug 1327589 (STR_1) and bug 1606260 are still valid, so it would probably be best to re-open them (or mark as Wontfix).

Daisuke-san, what would be the best approach in this case? Thank you!

Status: RESOLVED → VERIFIED
status-firefox87: fixed → verified
Flags: needinfo?(daisuke)

Hi Petruta-san, thank you very much for letting me know about them!
I took a look at them, it seems that the bugs are not fixed yet, as you said.
I will re-open them.
Thanks!

Flags: needinfo?(daisuke)
Regressions: 1701638
Regressions: 1709971
Regressions: 1710289
Regressions: 1834218
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: