Closed
Bug 1185453
Opened 9 years ago
Closed 9 years ago
Enable error summary file generation.
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Release Engineering
Applications: MozharnessCore
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: jgraham, Assigned: jgraham)
References
Details
Attachments
(1 file)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=888dcd198f30 - notice the [suite]_errorsummary.log files.
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1185453 - Generate error summary files for failures, r?chmanchester
Attachment #8635932 -
Flags: review?(cmanchester)
Comment 2•9 years ago
|
||
Comment on attachment 8635932 [details]
MozReview Request: Bug 1185453 - Generate error summary files for failures, r?chmanchester
https://reviewboard.mozilla.org/r/13605/#review12251
::: testing/config/mozharness/android_arm_4_3_config.py:91
(Diff revision 1)
> + "--app=%(app)s",
> + "--ignore-window-size",
> "--dm_trans=adb",
> "--bootstrap",
> - "--remote-webserver=%(remote_webserver)s", "--xre-path=%(xre_path)s",
> + "--remote-webserver=%(remote_webserver)s",
All this random reformatting makes this patch a pain to review.
::: testing/config/mozharness/android_arm_config.py:97
(Diff revision 1)
> - "options": [ "--app=%(app)s", "--ignore-window-size",
> + "options": [ "--app=%(app)s",
This started getting inconsistent, the first item is on a new line in other entries.
::: testing/mozharness/mozharness.json:1
(Diff revision 1)
> {
> - "repo": "https://hg.mozilla.org/build/mozharness",
> - "revision": "239491bc393a"
> + "repo": "https://hg.mozilla.org/users/james_hoppipolla.co.uk/mozharness",
> + "revision": "04c69b07c826"
> }
This is defunct.
::: testing/mozharness/scripts/androidx86_emulator_unittest.py:423
(Diff revision 1)
> + '%s_errorsummary.log' % suite_name)
Weird indentation.
::: testing/mozharness/scripts/web_platform_tests.py:127
(Diff revision 1)
> - "--stackwalk-binary=%s" % self.query_minidump_stackwalk()]
> + "--stackwalk-binary=%s" % "/home/jgraham/Downloads/minidump_stackwalk"]
Obviously don't check this in.
Attachment #8635932 -
Flags: review?(cmanchester) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://reviewboard.mozilla.org/r/13605/#review12251
> All this random reformatting makes this patch a pain to review.
Yeah, it should have been two commits, but it was hard to split out. Sorry.
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8635932 [details]
MozReview Request: Bug 1185453 - Generate error summary files for failures, r?chmanchester
Bug 1185453 - Generate error summary files for failures, r?chmanchester
Attachment #8635932 -
Flags: review+ → review?(cmanchester)
Updated•9 years ago
|
Attachment #8635932 -
Flags: review?(cmanchester) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8635932 [details]
MozReview Request: Bug 1185453 - Generate error summary files for failures, r?chmanchester
https://reviewboard.mozilla.org/r/13605/#review12337
Ship It!
Assignee | ||
Comment 6•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/df2c4d64382042e7a5f16c28835552239d29e65d
changeset: df2c4d64382042e7a5f16c28835552239d29e65d
user: James Graham <james@hoppipolla.co.uk>
date: Mon Jul 20 10:39:03 2015 +0100
description:
Bug 1185453 - Generate error summary files for failures, r=chmanchester
Comment 7•9 years ago
|
||
sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=11997787&repo=mozilla-inbound
Flags: needinfo?(james)
Assignee | ||
Comment 9•9 years ago
|
||
url: https://hg.mozilla.org/build/mozharness/rev/8978f498da2b542967df7fb5957cf1cc29769b70
changeset: 8978f498da2b542967df7fb5957cf1cc29769b70
user: James Graham <james@hoppipolla.co.uk>
date: Fri Jul 24 17:45:50 2015 +0100
description:
Bug 1185453 - Generate error summary files for failures, r=chmanchester
Assignee | ||
Comment 10•9 years ago
|
||
Comment 11•9 years ago
|
||
mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/2da0b7595468
Assignee | ||
Comment 12•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/fcaafcb5f0eee5428d104a5e8d0c21043da6041a
changeset: fcaafcb5f0eee5428d104a5e8d0c21043da6041a
user: James Graham <james@hoppipolla.co.uk>
date: Mon Jul 20 10:39:03 2015 +0100
description:
Bug 1185453 - Generate error summary files for failures, r=chmanchester
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(james)
Comment 13•9 years ago
|
||
Assignee: nobody → james
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Comment 14•9 years ago
|
||
I tried looking at the try run in comment 0:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=888dcd198f30
But all the error summary links I found via the "job details" tab in Treeherder, eg:
http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/c9ad803031fa1c0238ee4d02fcf5e23ced8aa2623ff781abca130d3388bb369ad44477520bfe6b77390e1a99fb6d8c7828ce08e40340199ea08ffcc8140a37b5
http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/7bc711911a92a8c1052c1c23bcb62fd865330f26bd51c594570dd7c410ea235bb1559f0fc3dfc5b861f2d05630d06ed9893ed62b48639b3502ad70858e9f3b67
http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/1f3bb45e71fc3ed050325fa8a285ac8722db380691a376aa6a7e7372b3de8a0fe31fc8f08ab7c2470e1a4699681cc0e184670a89191f0568a8f477881c1dbc19
Return no content.
Is there something up with the error summaries, S3 or the links Treeherder generates (which is the same method as the other blobber_files URLs)?
Flags: needinfo?(james)
Assignee | ||
Comment 15•9 years ago
|
||
Ah, I forgot to answer this in the bug. This is working as intended; unfortunately the error summaries for successful jobs are currently zero-length files that nevertheless get uploaded. It would be nice to fix this in the future, but it's a polish issue rather than fundamental brokenness.
Flags: needinfo?(james)
You need to log in
before you can comment on or make changes to this bug.
Description
•