Closed
Bug 1185956
Opened 9 years ago
Closed 9 years ago
Windows 10: border-color and box-shadow of URL bar and search field should be animated
Categories
(Firefox :: Theme, defect, P4)
Tracking
()
VERIFIED
FIXED
Firefox 42
People
(Reporter: phlsa, Assigned: jaws)
References
Details
(Whiteboard: [bugday-20150805])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
dao
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Let's add a subtle transition to the border of the URL bar and search field on Windows 10.
Can be done by adding this:
> transition-property: border-color, box-shadow;
> transition-duration: 0.1s;
to this rule:
https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#1223
|
||
Updated•9 years ago
|
Priority: -- → P4
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8637362 -
Flags: review?(dao)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8637362 [details] [diff] [review]
Patch
Seems like you should just set the transition in the win10 media query rather than resetting it to none for vista, win7 and win8 && :not(:-moz-lwtheme).
Attachment #8637362 -
Flags: review?(dao) → review-
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8637362 -
Attachment is obsolete: true
Attachment #8638102 -
Flags: review?(dao)
|
|
||
Updated•9 years ago
|
Attachment #8638102 -
Flags: review?(dao) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
|
||
Comment 6•9 years ago
|
||
Successfully reproduce in Nightly 42.0a1 (2015-07-21) (Build ID: 20150721030212) on Windows 10 64 Bit.
This Bug is now verified as fixed on Latest Nightly 42.0a1 (2015-08-05)
Build ID: 20150805030208
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:42.0) Gecko/20100101 Firefox/42.0
QA Whiteboard: [bugday-20150805]
OS: Unspecified → Windows 10
Hardware: Unspecified → All
Whiteboard: [bugday-20150805]
|
||
Updated•9 years ago
|
Status: RESOLVED → VERIFIED
|
||
Comment 7•9 years ago
|
||
Should we uplift to 41? Maybe not super important on its own, but it'll help make things look polished + ease other uplifts if there aren't subtle differences like this one.
Flags: needinfo?(jaws)
|
|
Assignee | |
Comment 8•9 years ago
|
||
Comment on attachment 8638102 [details] [diff] [review]
Patch v2
Approval Request Comment
[Feature/regressing bug #]: Theme polish for Windows 10
[User impact if declined]: less polished UI
[Describe test coverage new/current, TreeHerder]: manual testing
[Risks and why]: none, simple CSS fix
[String/UUID change made/needed]: none
This is a very simple low risk CSS change that we should uplift to 41, being closer to the Windows 10 release.
Flags: needinfo?(jaws)
Attachment #8638102 -
Flags: approval-mozilla-aurora?
status-firefox41:
--- → affected
Comment on attachment 8638102 [details] [diff] [review]
Patch v2
Verified on Nightly. Aurora+
Attachment #8638102 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 10•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•