Closed
Bug 1194590
Opened 9 years ago
Closed 9 years ago
URL and search bar border and box-shadow transition should only be used for the default theme
Categories
(Firefox :: Theme, defect, P3)
Tracking
()
VERIFIED
FIXED
Firefox 43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
(Whiteboard: [testday-20150901])
Attachments
(1 file)
|
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
We're only changing the border color and adding a box-shadow on hover and focus for the default theme.
Attachment #8647902 -
Flags: review?(jaws)
|
Assignee | |
Updated•9 years ago
|
OS: Unspecified → Windows 10
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8647902 [details] [diff] [review]
patch
Review of attachment 8647902 [details] [diff] [review]:
-----------------------------------------------------------------
This probably wants uplift. :-(
Attachment #8647902 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Updated•9 years ago
|
Flags: qe-verify-
|
||
Comment 3•9 years ago
|
||
I'm not sure I understand the impact here. What's the UX for users on the non-default theme with this?
Flags: needinfo?(dao)
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
|
|
Assignee | |
Comment 5•9 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #3)
> I'm not sure I understand the impact here. What's the UX for users on the
> non-default theme with this?
There's no visible impact.
Flags: needinfo?(dao)
|
||
Comment 6•9 years ago
|
||
This has been verified fixed in a QA test day.
Status: RESOLVED → VERIFIED
Whiteboard: [testday-20150901]
You need to log in
before you can comment on or make changes to this bug.
Description
•