Add to homescreen will be replaced with pinning in 2.5

I believe this is already fixed as part of earlier pin-the-web work. I don't see it in the context menu anymore so I'm closing for now. Feel free to re-open if I'm wrong.

Discussed in IRC, let's use this bug to track the work to remove "Add to homescreen" entirely once Pin the Web is on by default. Currently you switch between add to homescreen and pin with a pref.

We also want to use this bug for removing the setting behind which pin-the-web is hidden. This is a non-user facing feature, and so it doesn't block 2.5.

Let's disable the bookmark marionette js tests for the new homescreen for the time being, since they are flaky and they test a code path we won't support after 2.5. When we land this bug, let's just remove the tests completely.

Comment on attachment 8684983 [details] [gaia] mikehenrty:bug-1187392-disable-bookmark-tests > mozilla-b2g:master Chris, can you give the rubber stamp here?

Comment on attachment 8684983 [details] [gaia] mikehenrty:bug-1187392-disable-bookmark-tests > mozilla-b2g:master Unfortunately not, sorry :( bookmark_test can be disabled because (as you pointed out on IRC) it's covered by the pinning_the_web test... But the rest of them are testing functionality that no other marionette test hits. We'd need to replace the bit in these tests that opens and saves a bookmark with a bit that opens and pins a site instead (which ought to be trivial, I think?) Personally, I'd prefer to keep bookmark_test and do the same search/replace there too, I'd like to keep the tests as (for the most part) one-test-per-file (then the pinning-the-web test could be reduced to a pin-page test, I would guess?)

Yeah, you're probably right, we should manually convert each test. My hope was that we had enough functionality coverage in our existing pin the web tests such that we could just remove the bookmark tests. Better to convert, and indeed that was my idea in bug 1215524.

Firefox OS is not being worked on