Closed
Bug 1191403
Opened 9 years ago
Closed 9 years ago
Set a custom user-agent for nodejs client requests
Categories
(Tree Management Graveyard :: Treeherder: Client Libraries, defect, P2)
Tree Management Graveyard
Treeherder: Client Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: garndt, Assigned: emorley)
References
Details
Attachments
(1 file)
Similiar to bug 1186918, we should be setting the client and version in the user agent header.
Perhaps "treeherder-node/{{version}}"
Assignee | ||
Comment 1•9 years ago
|
||
The Python client is now using "treeherder-pyclient/X.Y.Z" - perhaps "treeherder-nodeclient/..." would be more consistent?
Assignee | ||
Updated•9 years ago
|
Priority: -- → P2
Assignee | ||
Comment 2•9 years ago
|
||
Digging around GitHub, there are two repos that make direct requests to Treeherder's APIs:
https://github.com/mozilla/treeherder-node
https://github.com/taskcluster/mozilla-taskcluster
And then the following also use treeherder-node (called mozilla-treeherder on npm) so will need updating to the new release, once one is made:
https://github.com/taskcluster/mozilla-taskcluster
https://github.com/mozilla/autolander
https://github.com/lightsofapollo/gaia-taskcluster
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•9 years ago
|
||
> And then the following also use treeherder-node
Also:
https://github.com/taskcluster/taskcluster-treeherder
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8719568 -
Flags: review?(garndt)
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8719568 [details]
treeherder-node: Add a User Agent to Treeherder requests
this lgtm, thanks!
Attachment #8719568 -
Flags: review?(garndt) → review+
Comment 6•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder-node
https://github.com/mozilla/treeherder-node/commit/42eb6a768136f01f6d2562dfbfee1fa0bf4954bb
Bug 1191403 - Add a User Agent to requests made to Treeherder
The Python client's user agent is 'treeherder-pyclient/...', so I've
chosen 'treeherder-nodeclient/...' for consistency.
https://github.com/mozilla/treeherder-node/commit/7543675e37b13e2d57f7afdd6ae96d02b092afb9
Merge pull request #8 from edmorley/treeherder-user-agent
Bug 1191403 - Add a User Agent to requests made to Treeherder
Reporter | ||
Comment 7•9 years ago
|
||
Merged and published 0.7.0 to npm
Reporter | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•9 years ago
|
||
Thank you :-)
Updated•4 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•