Closed Bug 1191403 Opened 9 years ago Closed 9 years ago

Set a custom user-agent for nodejs client requests

Categories

(Tree Management Graveyard :: Treeherder: Client Libraries, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: garndt, Assigned: emorley)

References

Details

Attachments

(1 file)

Similiar to bug 1186918, we should be setting the client and version in the user agent header. Perhaps "treeherder-node/{{version}}"
The Python client is now using "treeherder-pyclient/X.Y.Z" - perhaps "treeherder-nodeclient/..." would be more consistent?
Priority: -- → P2
Blocks: 1230222
Digging around GitHub, there are two repos that make direct requests to Treeherder's APIs: https://github.com/mozilla/treeherder-node https://github.com/taskcluster/mozilla-taskcluster And then the following also use treeherder-node (called mozilla-treeherder on npm) so will need updating to the new release, once one is made: https://github.com/taskcluster/mozilla-taskcluster https://github.com/mozilla/autolander https://github.com/lightsofapollo/gaia-taskcluster
Assignee: nobody → emorley
Status: NEW → ASSIGNED
> And then the following also use treeherder-node Also: https://github.com/taskcluster/taskcluster-treeherder
Attachment #8719568 - Flags: review?(garndt)
Comment on attachment 8719568 [details] treeherder-node: Add a User Agent to Treeherder requests this lgtm, thanks!
Attachment #8719568 - Flags: review?(garndt) → review+
Commits pushed to master at https://github.com/mozilla/treeherder-node https://github.com/mozilla/treeherder-node/commit/42eb6a768136f01f6d2562dfbfee1fa0bf4954bb Bug 1191403 - Add a User Agent to requests made to Treeherder The Python client's user agent is 'treeherder-pyclient/...', so I've chosen 'treeherder-nodeclient/...' for consistency. https://github.com/mozilla/treeherder-node/commit/7543675e37b13e2d57f7afdd6ae96d02b092afb9 Merge pull request #8 from edmorley/treeherder-user-agent Bug 1191403 - Add a User Agent to requests made to Treeherder
Merged and published 0.7.0 to npm
Blocks: 1248607
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Thank you :-)
Blocks: 1248650
Blocks: 1248676
Blocks: 1248932
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: