Closed
Bug 1194091
Opened 9 years ago
Closed 9 years ago
[browser] Firefox Account sync bookmark
Categories
(Firefox OS Graveyard :: Gaia::TV, defect, P1)
Tracking
(feature-b2g:2.5+)
People
(Reporter: yifan, Assigned: danhuang)
References
Details
(Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick])
Attachments
(7 files, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
text/x-github-pull-request
|
yifan
:
review+
|
Details |
|
(deleted),
text/x-github-pull-request
|
Details | |
|
(deleted),
text/x-github-pull-request
|
Details | |
|
(deleted),
text/x-github-pull-request
|
Details |
Implement Firefox Account default syncing in TV browser.
|
Reporter | |
Updated•9 years ago
|
Summary: [browser] Firefox Account sync default → [browser] Firefox Account sync bookmark
|
|
Reporter | |
Updated•9 years ago
|
Depends on: TV_FxAccount
|
|
Reporter | |
Updated•9 years ago
|
Blocks: TV_FxAccount
No longer depends on: TV_FxAccount
|
||
Updated•9 years ago
|
feature-b2g: --- → 2.5+
Whiteboard: [ft:conndevices][partner-blocker]
|
|
||
Updated•9 years ago
|
Target Milestone: --- → FxOS-S10 (30Oct)
|
|
Reporter | |
Updated•9 years ago
|
Assignee: nobody → yliao
Flags: needinfo?(yliao)
|
||
Comment 2•9 years ago
|
||
|
Assignee | |
Updated•9 years ago
|
Assignee: yliao → dhuang
|
|
||
Comment 3•9 years ago
|
||
|
|
Assignee | |
Comment 4•9 years ago
|
||
|
|
Assignee | |
Comment 5•9 years ago
|
||
Attachment #8676666 -
Attachment is obsolete: true
|
||
Comment 6•9 years ago
|
||
|
|
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 8677325 [details]
[gaia] danhuang1202:1194091_Firefox_Account_sync_bookmark > mozilla-b2g:master
Hi Yi-fan, please help me to review. This patch shows bookmark data from firefox account. Thanks.
Attachment #8677325 -
Flags: review?(yliao)
|
|
Reporter | |
Comment 8•9 years ago
|
||
Comment on attachment 8677325 [details]
[gaia] danhuang1202:1194091_Firefox_Account_sync_bookmark > mozilla-b2g:master
Thanks for the effort! Please see the comments.
Attachment #8677325 -
Flags: review?(yliao) → review-
|
|
Assignee | |
Comment 9•9 years ago
|
||
Comment on attachment 8677325 [details]
[gaia] danhuang1202:1194091_Firefox_Account_sync_bookmark > mozilla-b2g:master
Thanks for the review. I just fix the comments you suggested. Please help to review again, thanks.
Attachment #8677325 -
Flags: review- → review?(yliao)
|
|
Reporter | |
Comment 10•9 years ago
|
||
Comment on attachment 8677325 [details]
[gaia] danhuang1202:1194091_Firefox_Account_sync_bookmark > mozilla-b2g:master
Just a small nit. Good job! Thank you very much. Please squash the commits before merge.
Attachment #8677325 -
Flags: review?(yliao) → review+
|
|
Assignee | |
Comment 11•9 years ago
|
||
Thanks for the review on Saturday! Merge in master: https://github.com/mozilla-b2g/gaia/commit/75cc4d96c05bf865c5f2b78a75edb8b9f437c58e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Comment 12•9 years ago
|
||
|
|
||
Comment 13•9 years ago
|
||
|
||
Comment 14•9 years ago
|
||
Dan, the issue I reported you this morning has been resolved by bug 1218211, sorry for the false alarm.
|
|
||
Comment 15•9 years ago
|
||
|
|
Assignee | |
Comment 16•9 years ago
|
||
Ting, it's ok, never mind! Merge in master: https://github.com/mozilla-b2g/gaia/commit/45403ccae223372b9decaba08fa0ef03cc1d2f3d
|
|
Reporter | |
Updated•9 years ago
|
Whiteboard: [ft:conndevices][partner-blocker] → [ft:conndevices][partner-blocker][partner-cherry-pick]
You need to log in
before you can comment on or make changes to this bug.
Description
•