Closed
Bug 1212187
Opened 9 years ago
Closed 9 years ago
Update browser IndexedDB to adapt synced data from bookmarks datastores
Categories
(Firefox OS Graveyard :: Gaia::TV::Browser, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S9 (16Oct)
People
(Reporter: yifan, Assigned: selee)
References
Details
(Whiteboard: [partner-cherry-picked<2015/11/10>])
Attachments
(1 file)
Ensure that the data from bookmarks and places datastores can be seamlessly merged into browser IndexedDB.
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → yliao
Assignee | ||
Updated•9 years ago
|
Assignee: yliao → selee
Status: NEW → ASSIGNED
Summary: Update browser IndexedDB to adapt synced data from bookmarks and places datastores → Update browser IndexedDB to adapt synced data from bookmarks datastores
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8671980 [details]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1212187 > mozilla-b2g:master
Hey Yifan,
Could you help to review my patch? Thank you!
Attachment #8671980 -
Flags: review?(yliao)
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8671980 [details]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1212187 > mozilla-b2g:master
Clear yifan's review to refine the schema.
Attachment #8671980 -
Flags: review?(yliao)
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8671980 [details]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1212187 > mozilla-b2g:master
Hey Yifan, Could you help to review the patch? Thank you!
Attachment #8671980 -
Flags: review?(yliao)
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8671980 [details]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1212187 > mozilla-b2g:master
Thanks a lot for the effort! Please refer to the comments on Github.
Attachment #8671980 -
Flags: review?(yliao)
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8671980 [details]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1212187 > mozilla-b2g:master
Thanks Yifan! Let's do it one more round!
Attachment #8671980 -
Flags: review?(yliao)
Reporter | ||
Updated•9 years ago
|
Attachment #8671980 -
Flags: review?(yliao) → review+
Assignee | ||
Comment 7•9 years ago
|
||
landed on master: https://github.com/mozilla-b2g/gaia/commit/7bdf4f9737b838e2312a6c115c8c4c31508eac6c
gaia-test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=4d1ff2b17850c3ec3d9c6869b73e9a45e4338db4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 8•9 years ago
|
||
Sorry folks, but we need unit tests for this code.
Could you file a follow up for that and prioritize it, please? We are likely going to be touching this code next week and we cannot afford any regressions due to the time constrains that we have right now.
There are already some that can be taken as a start at [1].
[1] https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/browser/test/unit/browser_db_test.js
Flags: needinfo?(selee)
Assignee | ||
Comment 9•9 years ago
|
||
Let's do the test in this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1215436
Flags: needinfo?(selee)
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick] → [partner-cherry-picked<2015/11/10>]
You need to log in
before you can comment on or make changes to this bug.
Description
•