Closed
Bug 1198088
Opened 9 years ago
Closed 5 years ago
Wrong RTL Locales settings in the startup and newtab page
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
People
(Reporter: magicp.jp, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: rtl)
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150812163655
Steps to reproduce:
1. Run Firefox 40.0.2, 41.0 Beta 3, Developer Edition 42.0a2 and Nightly 43.0a1
2. Open startup and newtab page
3. Confirm side by side with the attached image
Actual results:
Please find wrong RTL Locales settings in the attached image
Expected results:
RTL Locales settings should be worked correctly.
Comment 1•9 years ago
|
||
magicp, is this a regression from previous releases?
Flags: needinfo?(magicp.jp)
This is degraded and regression. At least Firefox 32.0 is better than these version.
Bug 1178145
Bug 1178150
Bug 1198154
Flags: needinfo?(magicp.jp)
I have revised image file because the profile was affected by sync between LTR and RTL locales.
OS: Unspecified → All
Hardware: Unspecified → All
Version: 40 Branch → 43 Branch
Status: UNCONFIRMED → NEW
status-firefox41:
--- → affected
status-firefox42:
--- → affected
status-firefox43:
--- → affected
status-firefox44:
--- → affected
Ever confirmed: true
Version: 43 Branch → unspecified
Comment 4•9 years ago
|
||
The search bar content and the corresponding results are left aligned. I have confirmed layout problems since version 37 (I tested Hebrew), but the problems are most notable in Firefox 42+ (I tested 42b6 Arabic). I am able to address the issue in a theme I am supporting for the about:newtab page, but I know no way to change the layout of about:home from a theme.
Besides some failures in the style sheets (i.e., the need for an rtl search go arrow) a big problem is due to the rule (from html.css):
[dir="auto"]:-moz-dir(ltr) {
direction: ltr;
}
I actually override it theme with
[dir="auto"]:-moz-dir(ltr) {
direction: inherit;
}
In general -moz-dir() and -moz-locale-dir() are unreliable in about:home and about:newtab especially in the later versions of firefox. The pages state body[dir=...] as an alternative for the selectors. So I could have used
body[dir=rtl] [dir=auto]{
direction: rtl;
}
but this would not work on earlier versions of Firefox. I actually wrote a small script (for Stylish) that corrects the problem in about:home for Firefox 37-44:
@-moz-document url("about:home") {
[dir="auto"]:-moz-dir(ltr) {
direction: inherit;
}
body[dir=rtl] #searchForm{
position: relative;
}
body[dir=rtl] #searchForm > #searchSuggestionTable[style*="left"]{
right: 43px !important;
left:auto !important;
top: 38px !important;
}
body[dir=rtl] #searchForm > #searchText {
border-radius: 0 2.5px 2.5px 0;
}
body[dir=rtl] #searchForm > #searchSubmit {
border-radius: 2.5px 0 0 2.5px;
}
body[dir=rtl] #searchIconAndTextContainer #searchText {
padding-left: 0;
padding-right: 0;
-moz-padding-start: 34px;
-moz-padding-end: 8px;
border-radius: 0 2px 2px 0;
}
body[dir=rtl] #searchIconAndTextContainer #searchText[aria-expanded="true"] {
border-radius: 0 2px 0 0;
}
body[dir=rtl] #searchIconAndTextContainer #searchSubmit[value=""][aria-label]{
transform: scaleX(-1);
border: 1px solid;
border-color: hsla(210,54%,20%,.15) hsla(210,54%,20%,.17) hsla(210,54%,20%,.2);
border-radius: 0 2px 2px 0;
-moz-border-start: 1px solid hsla(210,54%,20%,.17);
-moz-border-end: 1px solid transparent;
}
body[dir=rtl] #searchIconAndTextContainer .contentSearchSuggestionTable:not([style*="left"]){
left: auto;
right: 0;
}
.contentSearchHeaderRow > td > img,
.contentSearchSuggestionRow > td > .historyIcon{
margin-right: 0;
-moz-margin-end: 8px;
}
}
(it has some redundant code!) The proper corrections (not the code above) should be made in
chrome://browser/content/searchSuggestionUI.css
chrome://browser/content/abouthome/aboutHome.css
As a theme developer, it's a pity that it I cannot solve the issue from a theme. Corresponding corrections should also be made in:
chrome://browser/content/newtab/newTab.css
or in
chrome://browser/skin/newtab/newTab.css
as I did in my theme.
status-firefox46:
--- → affected
status-firefox47:
--- → affected
Having visible bugs in about:home and about:newtab long time, There are critical issues as losing the trust of Firefox for RTL language users.
There's an entirely different UI now which seems to be RTL friendly.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Updated•2 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•