Dão Gottwald [:dao] Reporter
	Description • 9 years ago

Obviously (to us), the shortcut isn't going to work for background tabs. This might confuse users.

See also my patch for bug 1199609

	(no longer active) Assignee
	Comment 1 • 9 years ago

Yes, agreed.

	(no longer active) Assignee
	Comment 2 • 9 years ago

This will add new strings, so it won't block shipping.

	Jared Wein [:jaws] (please needinfo? me)
	Comment 4 • 9 years ago

Comment on attachment 8655153 [details] [diff] [review]
Don't show the keyboard shortcut in the tooltip text for the tab audio indicator on background tabs

Review of attachment 8655153 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/tabbrowser.xml
@@ +3965,5 @@
> +              label = stringWithShortcut(stringID, "key_toggleMute");
> +            } else {
> +              let stringID = tab.linkedBrowser.audioMuted ?
> +                "tabs.unmuteAudio.background.tooltip" :
> +                "tabs.muteAudio.background.tooltip";

Pull the `let stringId = ...` part outside of the if/else as it is duplicated in each block.

	Pulsebot
	Comment 5 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c3b14c7ffd9

	Carsten Book [:Tomcat]
	Comment 6 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/0c3b14c7ffd9

	Camelia Badau [:cbadau], Desktop QA
	Comment 7 • 9 years ago

Verified fixed on latest Aurora 43.0a2 (buildID: 20151011004016).