Closed Bug 1188860 (tab-sound-indicator) Opened 9 years ago Closed 9 years ago

[Meta] Metabug for tab sound indicator

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox42 --- fixed
relnote-firefox --- 42+

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Depends on 5 open bugs, Blocks 2 open bugs)

Details

(Keywords: feature, meta, user-doc-needed)

Attachments

(1 file)

Enable tab audio indicators and muting by default on desktop
(deleted), patch
jaws
: review+
Details | Diff | Splinter Review
This is a tracker bug for shipping the feature implemented in bug 486262. Currently, the pref disables itself when the feature hits beta. I'm adding the current bugs that we know we need to fix before we ship as dependencies here.
Keywords: relnote, user-doc-needed
Depends on: 1189759
Blocks: 1189772
No longer blocks: 1189772
Depends on: 1189772
Depends on: 1189885
Depends on: 1190023
Depends on: 1190040
Keywords: feature
relnote-firefox: --- → ?
Depends on: 1190023
No longer depends on: 1189759
Depends on: 1190081
Depends on: 1190096
Depends on: 1186632
Depends on: 1186633
Depends on: 1188114
Depends on: 1188978
Depends on: 1189759
Depends on: 1190103
Depends on: 1190106
Depends on: 1189796
Depends on: 1190192
we are no longer using the relnote keyword. relnote-firefox is better.
Keywords: relnote
Depends on: 1190924
Depends on: 1191038
Depends on: 1188548
Depends on: 1191081
Lawrence proposed that: Release Note Request (optional, but appreciated) [Why is this notable]: No more searching for the noisy tab. Tab audio indicators with mute button. https://twitter.com/mmmandel/status/626874461686497280 [Suggested wording]: New: Easily identify tabs playing audio and mute audio per tab [Links (documentation, blog post, etc)]: http://ehsanakhgari.org/blog/2015-07-30/tab-audio-indicators-and-muting-in-firefox-nightly and it seems that it is planned for 42.
Target Milestone: --- → Firefox 42
(In reply to Sylvestre Ledru [:sylvestre] from comment #2) > Lawrence proposed that: > > Release Note Request (optional, but appreciated) > [Why is this notable]: No more searching for the noisy tab. Tab audio > indicators with mute button. > https://twitter.com/mmmandel/status/626874461686497280 > [Suggested wording]: New: Easily identify tabs playing audio and mute audio > per tab > [Links (documentation, blog post, etc)]: > http://ehsanakhgari.org/blog/2015-07-30/tab-audio-indicators-and-muting-in- > firefox-nightly > > and it seems that it is planned for 42. Also note the additional UI we're implementing in bug 1189759.
Depends on: 1190924, 1189885, 1189796
Virtul_ManPL, please stop changing the bug dependencies. I have also sent you an email. Thanks!
No longer depends on: 1186632
No longer depends on: 1186633
Depends on: 1191437
Depends on: 1191491
Depends on: 1191958
Depends on: 1191940
No longer depends on: 1191958
No longer depends on: 1191940
Depends on: 1192063
Comment on attachment 8644704 [details] [diff] [review] Enable tab audio indicators and muting by default on desktop I'm planning to land this when we feel comfortable about all of the blockers being addressed, but we're pretty close so I might as well get review on this now!
Attachment #8644704 - Flags: review?(jaws)
Attachment #8644704 - Flags: review?(jaws) → review+
Depends on: 1192161
No longer depends on: 1188978
Depends on: 1192568
No longer depends on: 1191437
https://hg.mozilla.org/mozilla-central/rev/d10584967bb9
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Depends on: 1192974
Depends on: 1193085
Depends on: 1193191
No longer depends on: 1193191
Added to the 42 release notes "Audio tab indicator with muting capabilities" Better wording appreciated. I will add a link once the user doc is completed.
relnote-firefox: ? → 42+
[Suggested wording]: "Indicator added to tabs that play audio with one-click muting (Adobe Flash supported since version 19)"
Flags: needinfo?(sledru)
Much better, updated. Thanks!
Flags: needinfo?(sledru)
Depends on: 1193749
Depends on: 1193848
Sylvestre, please don't say anything about Flash support until we have a beta build that works, at the very least. (bug 1189772) Thanks!
Flags: needinfo?(sledru)
No longer depends on: 1193848
(In reply to (Ask others for review please; out most of the week) from comment #12) > Sylvestre, please don't say anything about Flash support until we have a > beta build that works, at the very least. (bug 1189772) Thanks! Nevermind, Adobe released a fix today.
Flags: needinfo?(sledru)
Depends on: 1194915
Depends on: 1195051
Depends on: 1195108
Depends on: 1195150
Depends on: 1196192
Depends on: 1197062
Depends on: 1200208
Depends on: 1199929
No longer depends on: 1199929
Depends on: 1213154
Blocks: 1215275
Depends on: 1220443
Depends on: 1222534
Depends on: 1223784
Depends on: 1224971
Blocks: 1225300
Depends on: 1221916
Depends on: 1231310
Depends on: 1231364
Depends on: 1231411
Blocks: 1120626
Depends on: 1242276
Depends on: 1196056
Depends on: 1245449
Blocks: 1249974
Depends on: 1301099
Depends on: 1325592
Depends on: 1331461
Depends on: 1345479
Depends on: 1345538
Depends on: 1346872
Depends on: 1472317
Depends on: 1474138
Blocks: 1634012

I would like to use this bug as a metabug to track all tab sound indicator related issues.

Keywords: meta
Summary: Tracking bug to ship the audio notification icon in Firefox tabs → [Meta] Metabug for tab sound indicator
Depends on: 1656414
Depends on: 1652460
Depends on: 1645668
Depends on: 1667270
Alias: tab-sound-icon → tab-sound-indicator
Depends on: 1346880
Depends on: 1601173
Depends on: 1684876
Depends on: 1707242
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: