Closed
Bug 1201539
Opened 9 years ago
Closed 9 years ago
Remove Fennec front-end code for reflow-on-zoom feature
Categories
(Firefox for Android Graveyard :: Toolbar, defect)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
So.. we still have this setting the advanced display settings in Fennec called "Text reflow". In the code this maps to the pref "browser.zoom.reflowOnZoom" which is supposed to control whether text is reflowed to fit the display width after a zoom. This is supposed to take effect after both a pinch-zoom and a double-tap-to-zoom.
However, enabling this setting seems to have no effect on a variety of pages I tested. At least it doesn't do what I recall it doing back in the day, where it rewraps text into a narrow column, often in page-layout-breaking ways (although it did help quite a lot with not having to scroll horizontally).
A number of bugs have been filed about this in the past (bug 1049063, bug 990821, etc.) which have been WONTFIXed. In general it seems like the feeling is that nobody has time to work on this feature and we can't really get it to the quality bar that we want. So I suggest killing it entirely and deleting the setting and relevant code from browser.js.
My main motivation is that removing this code will help with the APZ migration as there will be less hooks into the existing Java-based panning/zooming code. After the APZ migration if we want to reimplement this feature we can do it in C++ with the new APZ code, but that may or may not ever happen.
Assignee | ||
Comment 2•9 years ago
|
||
Actually, never mind. The decision was already made back in bug 1049063, so I'm just going to go ahead and delete the browser.js code. Bug 1059014 is on file for removing the layout-side code but I don't care so much about that for now so I'll leave that bug to track that deletion.
Flags: needinfo?(mark.finkle)
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
Summary: Apply "great or dead" razor to reflow-on-zoom functionality → Remove Fennec front-end code for reflow-on-zoom feature
Assignee | ||
Comment 3•9 years ago
|
||
green try |
Attachment #8656631 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 4•9 years ago
|
||
Try is green (the Android 4.0 failures are expected - those jobs are hidden on m-c).
Comment 5•9 years ago
|
||
Comment on attachment 8656631 [details] [diff] [review]
Delete stuff
Looks like you have everything covered.
Attachment #8656631 -
Flags: review?(mark.finkle) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•