Closed Bug 1204241 Opened 9 years ago Closed 4 years ago

"One off buttons" list doesn't update when I press Ctrl+Up/Down in Searchbar

Categories

(Firefox :: Search, defect, P5)

defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox43 --- affected

People

(Reporter: arni2033, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

STR: (Win7_64, Nightly 43, 32bit, ID 20150910030225, new profile, safe mode) 1. Click textarea in the searchbar 2. Hold Ctrl+Up for ~5 seconds to set the 1st engine in the list as the default engine 3. Click the magnifier dropmarker in the searchbar to collapse "one off buttons" list 4. Type something in the searchbar 5. Click the magnifier dropmarker in the searchbar to open "one off buttons" list 6. Press Ctrl+Down Result: "One off buttons" list doesn't display the 1st search engine in the list, So there's no way to use "Click on 'one off button' to search using the corresponding engine" Expectations: That list should display the 1st engine
Arni, thanks for filling this! I'm not sure I understand, you're changing the default search engine using Ctrl+Up/Down while the Options-Search page is opened? If that's the case, this is already logged in bug 1122618, please check and confirm. If not, please provide more info. Thank you!
No, you're talking about bug 1192777 which I also filed. I'll mark it as duplicate of 1122618 soon. In this bug I opened about:preferences#search only to show that 1st engine in the list is Google, and it [Google] doesn't show up in "one off buttons" list which is opened from searchbar. http://ssmaker.ru/0da10b9d.png Is it clear now? If not, I'll send a video.
Thanks, I see now. That's because the search bar drop-down is not updated every time the default search engine is switched, it only updates after it is closed are re-opened. This was discussed in another bug, I'll try to find it and come back with more info.
I actually think that 1109851 would fix this (and some more issues), but only if it won't be marked as Wontfix (it looks like an enhancement of brand new searchbar, which in turn has many regressions). If it *will* maked as Wontfix, then all other issues including this one will still be valid.
Depends on: 1109851
This is a valid bug (may be a duplicate, I remember we discussed this a few months ago), but a low priority one, in that this issue is only a minor inconvenience, there's an easy workaround (close the search panel eg. with the escape key and it will reopen updated as soon as you type more in the search field) so I don't think this prevents anybody from using the searchbar. I'm unlikely to fix this myself, but I would certainly review a patch.
Severity: normal → minor
Priority: -- → P4
Whiteboard: [fxsearch]
Rank: 47
Blocks: 1211485
Has STR: --- → yes
Priority: P4 → P5
May be fixed updating drop-down search bar every time the search engine is switched, or fixing bug 1469787.

As far as I can tell this is now working fine on the latest nightly.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: