Closed Bug 1204808 Opened 9 years ago Closed 9 years ago

Move DevTools prefs to their own new file

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: jryans, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 4 obsolete files)

patch v4
(deleted), patch
jryans
: review+
Details | Diff | Splinter Review
Since DevTools will soon have its own /devtools directory, it makes sense to pull the prefs out of browser and toolkit and into our own files.
Attached patch patch v1 (obsolete) (deleted) — — Splinter Review
Attached patch patch v2 (obsolete) (deleted) — — Splinter Review
Rebased, that's the kind of patch to land quickly as it will bitrot anytime someone tweaks any devtools pref! The last try looks promising.
Attachment #8671391 - Attachment is obsolete: true
Attached patch patch v2 (obsolete) (deleted) — — Splinter Review
Who else do you think I should flag for review regarding browser / moz.build changes?
Attachment #8671622 - Attachment is obsolete: true
Attachment #8672640 - Flags: review?(jryans)
Assignee: nobody → poirot.alex
Comment on attachment 8672640 [details] [diff] [review] patch v2 Review of attachment 8672640 [details] [diff] [review]: ----------------------------------------------------------------- I suppose you could ask :glandium for review, but the changes mostly seem "obvious" to me... Maybe we don't need additional review? ::: browser/installer/package-manifest.in @@ +687,5 @@ > > ; DevTools > @RESPATH@/browser/chrome/devtools@JAREXT@ > @RESPATH@/browser/chrome/devtools.manifest > +@RESPATH@/browser/defaults/preferences/preferences.js Since our prefs file gets packaged in directory with other prefs files, it seems like `devtools.js` would be a much better name. Also, other pref files in here use the format: @RESPATH@/browser/@PREF_DIR@/<FILE> ::: devtools/client/moz.build @@ +51,5 @@ > > JAR_MANIFESTS += ['jar.mn'] > > +JS_PREFERENCE_FILES += [ > + 'preferences.js', Assuming you rename it to something DevTools specific, maybe we should move the file under a prefs directory? That way a file like `devtools.js` is not misinterpreted to be some main JS module.
Attachment #8672640 - Flags: review?(jryans)
Attached patch patch v3 (obsolete) (deleted) — — Splinter Review
Renamed to devtools and use @PREF_DIR@.
Attachment #8672640 - Attachment is obsolete: true
Attachment #8672679 - Flags: review?(jryans)
Comment on attachment 8672679 [details] [diff] [review] patch v3 Review of attachment 8672679 [details] [diff] [review]: ----------------------------------------------------------------- Seems like you forgot to add the moz.build file in preferences to your patch.
Attachment #8672679 - Flags: review?(jryans)
Attached patch patch v4 (deleted) — — Splinter Review
With the moz.build...
Attachment #8672679 - Attachment is obsolete: true
Attachment #8673119 - Flags: review?(jryans)
Comment on attachment 8673119 [details] [diff] [review] patch v4 Review of attachment 8673119 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks for working on this!
Attachment #8673119 - Flags: review?(jryans) → review+
https://hg.mozilla.org/integration/fx-team/rev/2801520e5965ec09e8b31fa1954a0699fa1a7aa8 Bug 1204808 - Move devtools prefs to its own file in /devtools folder. r=jryans
https://hg.mozilla.org/mozilla-central/rev/2801520e5965
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: