Closed
Bug 1205906
Opened 9 years ago
Closed 9 years ago
Add schema and docs for validating text_log_summary artifacts
Categories
(Tree Management :: Treeherder: Data Ingestion, defect)
Tree Management
Treeherder: Data Ingestion
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: camd, Assigned: camd)
References
Details
Attachments
(1 file)
Need an endpoint for this.
Comment 1•9 years ago
|
||
Would exposing the jsonschema definition be enough?
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8663001 -
Flags: review?(emorley)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → cdawson
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Mauro Doglio [:mdoglio] from comment #1)
> Would exposing the jsonschema definition be enough?
I suppose that might have been enough. But this was easy enough to do and fit in with some of the other work I was doing.
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8663001 [details]
PR
Mauro-- Well, since you asked... Assigning this one to you. :)
Attachment #8663001 -
Flags: review?(emorley) → review?(mdoglio)
Comment 5•9 years ago
|
||
Comment on attachment 8663001 [details]
PR
I left some comments, please r? again when ready.
Attachment #8663001 -
Flags: review?(mdoglio)
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8663001 [details]
PR
I reduced the scope of this to only provide the schema file and some docs on how to validate with it.
Attachment #8663001 -
Flags: review?(emorley)
Updated•9 years ago
|
Status: NEW → ASSIGNED
Summary: Need a way to validate text_log_summary artifacts prior to submission → Add schema and docs for validating text_log_summary artifacts
Comment 7•9 years ago
|
||
Comment on attachment 8663001 [details]
PR
Looks good - left some comments :-)
I'd love us to overhaul the schema for these artifacts (eg bug 1078450) - but I imagine that will happen naturally as part of the json logs/failure signatures work.
Attachment #8663001 -
Flags: review?(emorley) → review+
Comment 9•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/4a4efd6e765456f60061c1ee179772aa631de573
Bug 1205906 - Adds JSON schema for text_log_summary artifacts
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•9 years ago
|
||
Ed, yeah, these artifacts could use some attention and refinement. And I agree we'll likely address that with the upcoming work.
You need to log in
before you can comment on or make changes to this bug.
Description
•