In bug 1183061 we are tracking the work needed to build with Android SDK 23. This does not include setting targetSdkVersion to 23 (to get the new API features) because this will require us to handle all kinds of behavior changes (new permission system, auto backup, ..). This is the meta bug to track exactly this work.

I just realized that I made a mistake in this commit: https://hg.mozilla.org/mozilla-central/rev/a51020a4a9c2 The mach based build (and therefore Nightly) has already targetSdkVersion set to 23 now. The "good" news is that when upgrading from targetSdkVersion 22 to 23 the app keeps all previous permissions. So Android M/6.0 users upgrading to the latest Nightly version will still have all permissions. The bad news is a fresh installation of Nightly on Android 6.0 will not have any permissions. To make things worse an app with targetSdkVersion=23 can't be downgraded to a version with targetSdkVersion=22: > Failed to finalize session : -26: Package org.mozilla.fennec_sebastian new target SDK 22 doesn't > support runtime permissions but the old target SDK 23 does. Accessing an API without the appropriate permission will throw a SecurityException. This is different to manually revoking a permission previously (with targetSdkVersion=22) where no exception was thrown. Should we go ahead and support runtime permissions in FxA 44? We could start by asking for all needed permissions at app start (To fix Nightly) and then move the requests to the place in code where they are actually needed.

The only other option I see is downgrading targetSdkVersion and basically stranding current Android 6.0 Nightly users (in the hope there are not many) until we go back to 23 (or they re-install).

My personal vote would be to go back and strand the nightly users...that's one of the risks you run when you install nightly software. I would also guess that there aren't *too* many of them - and the sooner it is rolled back, the fewer there will be. That's the whole purpose of having the nightly build anyway, isn't it? To find problems like this before they get too far along? BTW - those are just my personal opinions...so take it with a grain of salt.

(In reply to Sebastian Kaspari (:sebastian) from comment #1) > Should we go ahead and support runtime permissions in FxA 44? We could start > by asking for all needed permissions at app start (To fix Nightly) and then > move the requests to the place in code where they are actually needed. I don't think we feel we are ready to move to runtime permission support yet, right? I think we should flip back to SDK 22 and strand some nightly users. We can post to Twitter and the mailing list about the issue.

Argh. I thought @ANDROID_TARGET_SDK@ in AndroidManifest.xml.in is fed by ANDROID_TARGET_SDK in android.py. But it seems like this is always the same as the build SDK version and can't be configured independently. @nalexander: Is this correct?

(In reply to Sebastian Kaspari (:sebastian) from comment #5) > Argh. I thought @ANDROID_TARGET_SDK@ in AndroidManifest.xml.in is fed by > ANDROID_TARGET_SDK in android.py. But it seems like this is always the same > as the build SDK version and can't be configured independently. > > @nalexander: Is this correct? Unfortunately yes: mozboot is independent from the rest of the build system. Bug 1207680 tracks unifying this so that issues like this don't happen. ANDROID_TARGET_SDK comes from https://dxr.mozilla.org/mozilla-central/source/build/autoconf/android.m4#391, which comes from https://dxr.mozilla.org/mozilla-central/source/configure.in#4070.

This patch temporarily hardcodes targetSdkVersion to 22 in AndroidManifest.xml.

Comment on attachment 8671443 [details] [diff] [review] targetSdkVersion22.patch Review of attachment 8671443 [details] [diff] [review]: ----------------------------------------------------------------- Set Robocop's SDK version too.

Review commit: https://reviewboard.mozilla.org/r/28883/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/28883/

Comment on attachment 8703540 [details] MozReview Request: Bug 1207194 - Set targetSdkVersion to 23. r=nalexander I just bumped the hardcoded targetSdkVersion in AndroidManifest.xml.in instead of using the MOZ_* constant again (Just to avoid problem when the version numbers differentiate again)

Comment on attachment 8703540 [details] MozReview Request: Bug 1207194 - Set targetSdkVersion to 23. r=nalexander https://reviewboard.mozilla.org/r/28883/#review26311 There's no technical issue with this patch, only landing/ordering issues. I trust you to get those right :)

Comment on attachment 8703540 [details] MozReview Request: Bug 1207194 - Set targetSdkVersion to 23. r=nalexander Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28883/diff/1-2/

Comment on attachment 8703540 [details] MozReview Request: Bug 1207194 - Set targetSdkVersion to 23. r=nalexander Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28883/diff/2-3/

https://hg.mozilla.org/integration/fx-team/rev/581a08d46be49fb0ee708256e496ab6de8e8770e Bug 1207194 - Set targetSdkVersion to 23. r=nalexander