Closed
Bug 1210755
Opened 9 years ago
Closed 9 years ago
Switch to Android 6.0 SDK / API 23
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
All
Android
Tracking
(firefox44 fixed)
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: sebastian, Assigned: sebastian)
References
Details
Attachments
(3 files)
(deleted),
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
Patches for all build errors (meta bug 1183061) are landed or in review. This bug is tracking the work needed to actually switch to the new SDK.
Note that this bug is only about switching to the new SDK (and matching build tools) and not about setting targetSdkVersion to 23. This will require more work and this is tracked by meta bug 1207194.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8668931 -
Flags: review?(nalexander)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8668934 -
Flags: review?(nalexander)
Comment 3•9 years ago
|
||
Comment on attachment 8668931 [details] [diff] [review]
Gradle build: Compile with SDK version 23 and use build tools 23.0.1
Review of attachment 8668931 [details] [diff] [review]:
-----------------------------------------------------------------
Yep.
Attachment #8668931 -
Flags: review?(nalexander) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8668934 [details] [diff] [review]
Mach build: Compile with SDK version 23 and use build tools 23.0.1
Review of attachment 8668934 [details] [diff] [review]:
-----------------------------------------------------------------
Fire the missiles!
::: python/mozboot/mozboot/android.py
@@ +20,5 @@
> # These are the "Android packages" needed for building Firefox for Android.
> # Use |android list sdk --extended| to see these identifiers.
> ANDROID_PACKAGES = [
> 'tools',
> 'platform-tools-preview', # Temporarily, tools depends on platform-tools-preview.
Is this still accurate? I wonder if we're back to platform-tools?
Attachment #8668934 -
Flags: review?(nalexander) → review+
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Nick Alexander :nalexander from comment #4)
> Is this still accurate? I wonder if we're back to platform-tools?
Oh yeah, definitely. I'll look at that in a follow-up patch.
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Try build with new releng.manifest (Still building with API 22):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=84676097c3fe
Try build with new releng.manifest (Building with API 23 and all build patches applied):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=77838246b41a
Let's see how this turns out. :)
Assignee | ||
Comment 8•9 years ago
|
||
(In reply to Sebastian Kaspari (:sebastian) from comment #7)
> Try build with new releng.manifest (Still building with API 22):
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=84676097c3fe
>
> Try build with new releng.manifest (Building with API 23 and all build
> patches applied):
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=77838246b41a
>
> Let's see how this turns out. :)
All green \o/
Assignee | ||
Updated•9 years ago
|
Keywords: leave-open
Assignee | ||
Comment 10•9 years ago
|
||
Last sanity check before I push everything:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca73de452e8
Comment 11•9 years ago
|
||
Assignee | ||
Comment 12•9 years ago
|
||
leave-open: I'm going to add a patch for 'platform-tools-preview'.
Comment 14•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Keywords: leave-open
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 44 → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•