Tested using: Device: LG G4 (Android 5.1); Build: Firefox for Android 43.0a2 (2015-09-22); Steps to reproduce: 1. Go to about:telemetry Actual result: - "FHR data upload is disabled" - Tapping the "Change" button opens Mozilla submenu and "Aurora Health Report" preference is enabled - FHR data upload remains disabled in about:telemetry even if FHR pref in settings is checked or unchecked Expected result: - FHR data upload should be enabled in about:telemetry if FHR pref is enabled in settings Note: - reproducible on latest Nightly 44.0a1 and Aurora 43.0a2 - on 42 Beta 1 it's Bug 1178768 - 'Change' buttons in about:telemetry do not open the datachoices preferences on mobile - on desktop on latest Nightly "FHR data upload is enabled" by default in about:telemtry

Fennec tracks that setting elsewhere. Until we enable the Unified Telemetry features on Fennec, Telemetry upload is presumably controlled by a different pref there ("toolkit.telemetry.enabled"). We can just hide the "FHR data upload is disabled/enabled" section around here: https://dxr.mozilla.org/mozilla-central/rev/abe43c30d78d7546ed7c622c5cf62d265709cdfd/toolkit/content/aboutTelemetry.js#259 ... based on a constant `IS_UNIFIED` like here: https://dxr.mozilla.org/mozilla-central/rev/abe43c30d78d7546ed7c622c5cf62d265709cdfd/toolkit/components/telemetry/TelemetryController.jsm#48

Is this bug relevant now? Should we update about:telemetry to reflect our new opt-out data collection pref state?

(In reply to :Margaret Leibovic from comment #2) > Is this bug relevant now? Should we update about:telemetry to reflect our > new opt-out data collection pref state? Yeah. In order to ensure we don't have to wait for Gecko to start before upload, we switched to using a SharedPreference [1]: GeckoPreferences.PREFS_HEALTHREPORT_UPLOAD_ENABLED [2]. I previously filed bug 1241685 to link this SharedPreference and the Gecko preference Georg mentions in comment 1 ("toolkit.telemetry.enabled") which I think would solve this bug. Soft dep to bug 1241685, which will probably get duped. [1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/telemetry/TelemetryUploadService.java#106 [2]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java#118

Notes from vidyo w/ georg: * We only need to sync the Java on/off preference with the gecko preference only if we expect to do Gecko uploading of telemetry (hence waiting on the roadmap meeting) * It would be great to link the server preference though (bug 1241685), for testing purposes * We should see if flipping this preference affects the toolkit.telemetry.enabled preference (NI self) – though I can't entirely remember why...

(In reply to Michael Comella (:mcomella) from comment #4) > * We should see if flipping this preference affects the > toolkit.telemetry.enabled preference (NI self) – though I can't entirely > remember why... * |about:config -> toolkit.telemetry.enabled| changes |about:telemetry -> "Extended Telemetry recording is <value>"| * |about:telemetry -> "FHR data upload is <value>"| where <value> is always disabled. Clicking "Change" will bring you to the Java UI, which doesn't reflect the about:telemetry state or change it when the Java value is changed Since the about:telemetry FHR pref uses the same branding ("FHR") as the Java pref, it's unintuitive that they're not linked and display different values. If we were to link the pref, it'd be good to see how FHR did this in the past.

(Rewording title lightly) Even with the about:telemetry redesign, the mismatch of preferences between mobile and desktop Telemetry means about:telemetry on Fennec is still wrong. It seems, from [1], that the preference to report in about:telemetry on Fennec is, confusingly, android.not_a_preference.healthreport.uploadEnabled [1]: https://searchfox.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java#113