(no longer active) Assignee
	Description • 9 years ago

I need to install a couple of packages in the centos6-build docker image to support running build-clang.py in TaskCluster.

	Dustin J. Mitchell [:dustin] (he/him)
	Comment 2 • 9 years ago

Comment on attachment 8665393 [details] [diff] [review]
Add some packages to the new desktop-build docker image to support building clang

Review of attachment 8665393 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine, but note that glibc-devel.i686 will be installed by bug 1189892, which anyway will conflict with this.  Also, we should uninstall subversion at the end, to avoid shipping it around in the image unnecessarily.

Let's plan to land a rebased version of this, with subversion uninstalled, right after bug 1189892.

	(not currently active) Ted Mielczarek
	Comment 3 • 9 years ago

Er, we need subversion installed to run the build-clang script, which means it needs to be in the final image.

	(no longer active) Assignee
	Comment 4 • 9 years ago

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> Er, we need subversion installed to run the build-clang script, which means
> it needs to be in the final image.

Yeah, that's the whole point of this patch...

	Dustin J. Mitchell [:dustin] (he/him)
	Comment 5 • 9 years ago

Comment on attachment 8665393 [details] [diff] [review]
Add some packages to the new desktop-build docker image to support building clang

Review of attachment 8665393 [details] [diff] [review]:
-----------------------------------------------------------------

/me smacks forehead

	(no longer active) Assignee
	Comment 6 • 9 years ago

So should I land this?

	Dustin J. Mitchell [:dustin] (he/him)
	Comment 7 • 9 years ago

I rolled it into bug 1189892 attachment 8665909 [details] [diff] [review] which will hopefully land shortly.

	(no longer active) Assignee
	Comment 8 • 9 years ago

Thanks!

	(no longer active) Assignee
	Comment 9 • 9 years ago

The 0.1.4 version of the image doesn't have subversion installed.

Dustin, perhaps you didn't include that when you built the image?

	Dustin J. Mitchell [:dustin] (he/him)
	Comment 10 • 9 years ago

Hm, I think I got hosed by some hg merge in bug 1189892 -- lines that were supposed to go came back, and lines that were supposed to stay left :(

	Dustin J. Mitchell [:dustin] (he/him)
	Comment 11 • 9 years ago

Hm, the `install subversion` line was committed correctly -- I wonder if something funny went on with the image generation (maybe somehow using an older version of that image generated locally?)

I'll bump the VERSIONs, re-generate the images, verify svn is installed, docker push, and generate a patch with the new VERSIONs.

Sorry about that.  Getting automatic generation of docker images (bug 1132346) isn't quite on the critical path, but its absence sure is annoying.

	Dustin J. Mitchell [:dustin] (he/him)
	Comment 12 • 9 years ago

[root@taskcluster-worker ~]# svn
Type 'svn help' for usage.

	Dustin J. Mitchell [:dustin] (he/him)
	Comment 13 • 9 years ago

Bug 1208029: bump image version numbers to capture subversion install; r?ehsan

	(no longer active) Assignee
	Comment 14 • 9 years ago

Comment on attachment 8667864 [details]
MozReview Request: Bug 1208029: bump image version numbers to capture subversion install; r?ehsan

https://reviewboard.mozilla.org/r/20843/#review18727

Thanks for the quick fix!

	Dustin J. Mitchell [:dustin] (he/him)
	Comment 15 • 9 years ago

both images are already docker-push'd

	Pulsebot
	Comment 16 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/16b7f24721a1

	Carsten Book [:Tomcat]
	Comment 17 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/16b7f24721a1